Ticket #8837 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Incorrect dead time and grouping tables when spectra or entry specified for LoadMuonNexus

Reported by: Arturs Bekasovs Owned by: Raquel Alvarez Banos
Priority: major Milestone: Release 3.4
Component: Muon Keywords:
Cc: Blocked By: #11165, #11218
Blocking: Tester: KarlPalmen

Description

LoadMuonNexus returns dead times and grouping for all the spectra even if SpectrumMin/Max are set, and fails to get anything if Entry number is set.

Change History

comment:1 Changed 7 years ago by Arturs Bekasovs

  • Blocking 8835 added

(In #8835) This problem should be solved when I change the way it works.

comment:2 Changed 7 years ago by Arturs Bekasovs

  • Blocking 8835 removed

comment:3 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

bulk move to assigned at the into of the triage step

comment:4 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Arturs Bekasovs to Anders Markvardsen

comment:5 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Raquel Alvarez Banos

comment:6 Changed 6 years ago by Raquel Alvarez Banos

I have noticed the following:

  • Load MUSR00015189.nxs
  • Select SpectrumMin=1 and SpectrumMax=7
  • Select SpectrumList=15, 20

There is something wrong as the output workspace contains spectra from 1 to 9. At first glance it seems that the number of spectra loaded is correct (in this case from 1 to 7 plus two in SpectrumList) but the first spectrum loaded is always 1 and the rest of them are consecutive.

I am creating a new ticket to investigate this first.

comment:7 Changed 6 years ago by Raquel Alvarez Banos

  • Blocked By 11165 added

comment:7 Changed 6 years ago by Raquel Alvarez Banos

Ticket #11165 has been created.

comment:8 Changed 6 years ago by Raquel Alvarez Banos

  • Blocked By 11218 added

comment:8 Changed 6 years ago by Raquel Alvarez Banos

I see different problems here. On the one hand, dead times are not loaded correctly into a table when some spectra are specified. This is in principle easy to fix and will be addressed in the new ticket #11218. On the other hand, the algorithm fails if EntryNumber is set. This is related to the detector grouping loading and will be solved in the current ticket together with the grouping table issue.

comment:11 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from assigned to inprogress

Re #8837 Code refactoring

Changeset: c310d4742c81004dd470fb9bdf269a7f5ccf5d6b

comment:12 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Set list of spectra to load

Changeset: 3582061f90a54a388300fa5e1b02120eb79b6615

comment:13 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Set specToLoad at the beginning

Changeset: 583fbab815dbf46087248414f12b8365c3503bb5

comment:14 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Load dead times after checking specified spectra

Changeset: 71291c04f603c7cebfee85774807e91feae5aeda

comment:15 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Fix all-spectra case

Changeset: 817c1259632595a647794bb9bd9ce9058514f097

comment:16 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Check deadtime table in unit test

Changeset: a517593f28bb80935e8996557b67cbf4ec02966c

comment:17 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 check supplied spectra before loading detector grouping

Changeset: 96d0f452704d11a3d25bb131bbb3dd96361be0e2

comment:18 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Fix coverity issue

Changeset: bd48d7ece8a84d1ca4502a6000448ff820648009

comment:19 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Reorganising possible cases

Changeset: 8128db2342c598b7f1df2d376e7be7431a97b465

comment:20 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Refactor method to load detector grouping

Changeset: 05b3815eb941d239b3ba22e61341b6cd127866f9

comment:21 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Set selected spectra before loading detector grouping table

Changeset: a3628c239cace0e0ae50ec6297e68c461ef18195

comment:22 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Set spectra numbers selected by user

Changeset: d6cba4c1139ceb820a4e5f3f52dd62e2aa8fe5df

comment:23 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Set grouping for selected spectra only

Changeset: e92984536d71ffb7783069c899d05965981843dd

comment:24 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 If one period selected, get the correct grouping info

Changeset: 81774a2c3d3eaccbb0012356180216e41bc50b3b

comment:25 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Get the grouping and put it into table for every period

Changeset: 1b40db6a0d18089d0b757a8fffeb99366b4840ad

comment:26 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Clear grouping vector for each period

Changeset: c2bbb93b061766e6bc48dc68e41fdf986d0a947c

comment:27 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Handle properly single period datasets

Changeset: a95a653f04b183d76c3fe39fade89b7c430c290b

comment:28 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Use spectrum numbers when creating detector table

Changeset: 0f5b1d17e79c1033e099c3ee0a5a180bd4672f7e

comment:29 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Update SpectrumDetectorMapping according to selected spectra

Changeset: a089ad6db1649cebff78e3c2d258d4d508e3c2b4

comment:30 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Use detector grouping table in unit test

Changeset: 79eaaeb629b7056bbae5d91e28674665cb3cf6aa

comment:31 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Add user examples for dead time table and detector grouping

Changeset: d43c2b6b9bb1103b2b44b4b271be3f316f93180b

comment:32 Changed 6 years ago by Raquel Alvarez

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #368.

comment:33 Changed 6 years ago by Raquel Alvarez Banos

  • Milestone changed from Backlog to Release 3.4

comment:34 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Fix doxygen warnings

Changeset: 21812b53116a2700c56df10ee938f299f71d6303

comment:35 Changed 6 years ago by Raquel Alvarez

Jenkins, retest this please

comment:36 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Changing spectra to spectrum in message

Changeset: 2f773309e2b5fd8def431888d4b0ca6207a8f7b1

comment:37 Changed 6 years ago by Raquel Alvarez Banos

Re #8837 Correcting comment, it should be per spectrum

Changeset: 34c498589d62e91ac00a7c93dcf7d34085d12afd

comment:38 Changed 6 years ago by Raquel Alvarez

Thanks Karl, comments/messages have been corrected.

comment:39 Changed 6 years ago by Raquel Alvarez

Jenkins, retest this please

comment:40 Changed 6 years ago by Raquel Alvarez

Jenkins, retest this please

comment:41 Changed 6 years ago by Raquel Alvarez

Jenkins, retest this please

comment:42 Changed 6 years ago by Raquel Alvarez

Jenkins, retest this please

comment:43 Changed 6 years ago by Raquel Alvarez

Jenkins, retest this please

comment:44 Changed 6 years ago by Raquel Alvarez

Jenkins, retest this please

comment:45 Changed 6 years ago by KarlPalmen

  • Status changed from verify to closed
  • Tester set to KarlPalmen

Merge pull request #368 from mantidproject/8837_Fix_grouping_and_entry_number

Fix detector grouping and entry number

Full changeset: ​8bad04fb7b17523c19d6df54b0ec77068171b440

comment:46 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9681

Note: See TracTickets for help on using tickets.