Ticket #8842 (closed: fixed)
Indirect Diffraction: IRIS has broken option for diffonly
| Reported by: | Samuel Jackson | Owned by: | Samuel Jackson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.2 |
| Component: | Indirect Inelastic | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Jay Rainey |
Description
The diffonly option on the Indirect Diffraction interface for IRIS looks for the string value for the calibration file, but there is no option of the interface to provide a calibration file!
Consult with instrument scientist for advice on what should be done here.
Change History
comment:2 Changed 6 years ago by Samuel Jackson
- Status changed from assigned to inprogress
Refs #8842 Update system tests to match.
Changeset: 1645caaa3aada2eef0ec40c22acd7340f1b37853
comment:3 Changed 6 years ago by Samuel Jackson
Refs #8842 Ignore OSIRIS diffraction reduction for other instruments.
Changeset: a05de98a39bc3ac1d4cc0272c5152b3be1ea7f54
comment:4 Changed 6 years ago by Samuel Jackson
Refs #8842 Update instrument parameter files.
This adds support for TOSCA and VESUVIO in the IP files. VESUVIO still doesn't work with the standard reducer, but the interface will at least be fixed.
Changeset: 4134b6cac545505d422d2c775877489a62377178
comment:5 Changed 6 years ago by Samuel Jackson
Refs #8842 Fix incorrect instrument name in parameter file.
Changeset: 3f1fe4f738e4b1f440e49044648f944e5cac6a11
comment:6 Changed 6 years ago by Samuel Jackson
Refs #8842 Fix broken unit test.
TOSCA has an additional parameter now.
Changeset: f016cc04bb4b06b04c36a92a477a3c83d597b92a
comment:7 Changed 6 years ago by Samuel Jackson
To Test
Note that both the main repo and system tests need to be merged for this ticket.
First test the changes to TOSCA work:
- Open up the Indirect Diffraction interface.
- Select TOSCA and ensure only the diffspec option shows.
- Run using TSC11453.raw from the systests folder.
- Leave all other parameters as default
Then check OSIRIS DiffOnly still works:
- Select OSIRIS in diffonly mode
- Use the following data from the system tests:
- Sample: OSI89813.raw, OSI89814.raw, OSI89815.raw, OSI89816.raw, OSI89817.raw
- CalFile: osiris_041_RES10.cal
- Vanadium: OSI89757, OSI89758, OSI89759, OSI89760, OSI89761
Then check IRIS DiffOnly now works as well:
- Select IRIS in diffonly mode
- Use IRS21360.raw from the system tests and leave the other options as default.
comment:8 Changed 6 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:9 Changed 6 years ago by Jay Rainey
- Status changed from verify to verifying
- Tester set to Jay Rainey
comment:11 Changed 6 years ago by Jay Rainey
- Status changed from verifying to closed
To verify this, I ran an older version (3.1) of Mantid to see the output of OSIRIS and IRIS (TOSCA did not work). I then built and run this branch to verify the changes made address the TOSCA and IRIS DiffOnly issue. I also verified that the interface produces the correct results for OSIRIS, and IRIS, which they do (I verified this by comparing the output of Mantid 3.1 & a the local test build).
The code changes made are sensible and address the issue. The build servers, and system tests are passing.
comment:12 Changed 6 years ago by Jay Rainey
Merge remote-tracking branch 'origin/bugfix/8842_indirect_diffraction_bug'
Full changeset: 522d4caac99b6391f7742f361c151a4c42c2eb32
comment:13 Changed 6 years ago by Jay Rainey
Merge remote-tracking branch 'origin/bugfix/8842_indirect_diffraction_bug'
Full changeset: db180173218a2288728d519a48a284e64d8d3aaa
comment:14 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9686
bulk move to assigned at the into of the triage step