Ticket #8861 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fresh install of ScriptRepository is broken

Reported by: Martyn Gigg Owned by: Gesner Passos
Priority: blocker Milestone: Release 3.1
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Samuel Jackson

Description

To reproduce:

  • Remove anything referencing the script repo so that we can start clean;
  • Click File->Script Repository and then click okay
  • Click on something to download it, e.g. the muon folder
  • the results log shows an error: 'IndentationError: unexpected indent (<Interface>, line 2)'

I have noticed that the exact same error occurs when you go to View->Preferences->Mantid->Directories and then try to add a directory to the python scripts path. When you click apply you get the above error

Change History

comment:1 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress

re #8861: Fix the problem of identation in the python script

This python script is triggered when the python.directories changes. There are identation problems with it.

The problem was introduced in this commit 8557da27854b141ed2d4215632c395f5cc15d936, by auto-identation of editor.

The way to ensure it does not happen again is to allow the compiler to concatenate strings as now.

Changeset: bb60848929b8c6ce58454678c00622fc043c0936

comment:2 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester:

check that the error has gone. The description shows how to reproduce the error.

comment:3 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:4 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8861_handle_config_change'

Full changeset: ab9646b3bf7f36281f09f0b0cdc77392efa64da6

comment:5 Changed 7 years ago by Samuel Jackson

I checked I could reproduce, checked the change worked and checked the changes. It's all good.

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9705

Note: See TracTickets for help on using tickets.