Ticket #8881 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fix duplication in 'if' statement in SaveGSASInstrumentFile.cpp

Reported by: Russell Taylor Owned by: Wenduo Zhou
Priority: critical Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #8940 Tester: Martyn Gigg

Description (last modified by Wenduo Zhou) (diff)

Cppcheck has spotted the following duplicated (3 times!) test: 

if (m_vecCWL.size() != numbanks || m_vecCWL.size() != numbanks || m_vecCWL.size() != numbanks)

at line 143.

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Blocking 8940 added

comment:2 Changed 7 years ago by Wenduo Zhou

  • Status changed from new to inprogress

Fixed duplicate if error reported by cppcheck. Refs #8881.

Changeset: cc2a7413a75f29b5dd4c8721942d177df2d58404

comment:3 Changed 7 years ago by Wenduo Zhou

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Description modified (diff)

Please go to line 143 to see the change of code, check cpp build server, and check whether the unit tests and system tests do not break.

comment:4 Changed 7 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:5 Changed 7 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8881_fix_dup_if'

Full changeset: ​11e3ba510c9a619a43a5b1d7cdaa2264b5ce86fa

comment:6 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9725

Note: See TracTickets for help on using tickets.