Ticket #8884 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fail to load LARMOR data

Reported by: Gesner Passos Owned by: Gesner Passos
Priority: critical Milestone: Release 3.1
Component: SANS Keywords:
Cc: Blocked By:
Blocking: Tester: Peter Parker

Description

Changes applied in #8438 breaks what was implemented in #8395

Trying to load LARMOR data through the ISIS SANS interface fails. This is because, #8395 introduced a new way to load data and move components. It is an easy fix. But it must get into 3.1

Change History

comment:1 Changed 7 years ago by Gesner Passos

Besides load_transmission_inst changed signature.

comment:2 Changed 7 years ago by Gesner Passos

  • Status changed from new to inprogress

re #8884: Fix loading larmor data

Fixes the side effects of #8438 in the loading larmor data.

Changeset: 400b5597ddb0d8e7106b99c59f2fc6b5da49e4ad

comment:3 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

Tester:

Check that #8395 is working. I've put the simulated LARMOR data inside babylon Gesner Passos folder.

comment:4 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:5 Changed 7 years ago by Karl Palmen

  • Status changed from verifying to verify
  • Tester Karl Palmen deleted

I find I do not know how to check #8395 is working, in particular loading the mask and batch files elude me. I return to testing pool for someone more knowledgeable of SANS ISIS interface.

comment:6 Changed 7 years ago by Peter Parker

  • Status changed from verify to verifying
  • Tester set to Peter Parker

comment:7 Changed 7 years ago by Peter Parker

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8884_loading_larmor'

Full changeset: ​e1ccf42fa4a731eba118b811635691971eaebb3b

comment:8 Changed 7 years ago by Peter Parker

I was able to reproduce the problem and then see that it was fixed after the change.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9728

Note: See TracTickets for help on using tickets.