Ticket #8886 (closed: fixed)
dgreduce hard mask issue
| Reported by: | Alex Buts | Owned by: | Alex Buts |
|---|---|---|---|
| Priority: | blocker | Milestone: | Release 3.1 |
| Component: | Framework | Keywords: | |
| Cc: | nick.draper@…, jon.taylor@… | Blocked By: | |
| Blocking: | Tester: | Martyn Gigg |
Description
As described:
Hi seems that dgreduce really wants to have a hard mask specified in the command line, irrespective of if you have a hard mask or not.
(see error below)
Can we adjust this back to how it was as it kills all the mari scripts
We are still moving detectors to the specified positions in set.dat. The class attribute reallocate sets does not exist anymore
cheers jon
Attachments
Change History
comment:1 Changed 7 years ago by Alex Buts
- Status changed from new to inprogress
refs #8886 this should fix it
As no check if key is missing was implemented
Changeset: c92d12ee91c2ed48c475bb2e48d0b4a47f1401af
comment:3 Changed 7 years ago by Alex Buts
refs #8886 Unit test modified to check failing case as well.
Changeset: 52e38a039f3759b35032ed376860eac95f1976d2
comment:4 Changed 7 years ago by Alex Buts
- Status changed from inprogress to verify
- Resolution set to fixed
if one comment hard_mask_file key in System tests ISISDirectInelastic.py (e.g. row 193) the system test would fail as well.
But Not after this change has been applied.
comment:5 Changed 7 years ago by Alex Buts
refs #8886 fixing unit test
Changeset: f5168662f276397577e5fa1d480219cc4ae5f34c
comment:6 Changed 7 years ago by Alex Buts
refs #8886 Fixing unit test/DgreduceTest.py
(previous one went to wrong place)
Changeset: 88b8cd2b92a2eb1c3f8de5fa53e7d3352276a023
comment:7 Changed 7 years ago by Martyn Gigg
The first point has been fixed but has this addressed Jon's second point?
We are still moving detectors to the specified positions in set.dat. The class attribute reallocate sets does not exist anymore
comment:8 Changed 7 years ago by Martyn Gigg
- Status changed from verify to verifying
- Tester set to Martyn Gigg
comment:9 Changed 7 years ago by Martyn Gigg
- Status changed from verifying to closed
Confirmed that system test did not work before if hard mask file was not specified but it does now.
The second part to the description was confirmed old & and no longer valid with Jon.
comment:10 Changed 7 years ago by Martyn Gigg
Merge remote-tracking branch 'origin/bugfix/8886_dgreduceHardmaskfileIssue'
Full changeset: 16d0ec901173986704863ce7af20bb56e80dd0ff
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9730
