Ticket #8887 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Refl_gui not auto-calculating dq/q, qmin and qmax

Reported by: Keith Brown Owned by: Keith Brown
Priority: blocker Milestone: Release 3.1
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: #8883 Tester: Owen Arnold

Description

the gui used to fill in dq/q, qmin and qmax if no supplied, but it doesn't now. this must be fixed before release.

Change History

comment:1 Changed 7 years ago by Keith Brown

  • Status changed from new to inprogress

Refs #8887 Fixed problem that was stopping auto-calc

dq/q calculation was the problem that stopped everything occuring.

The gui now attempts to calculate dq/q if not present, but if the logs it needs aren't there it stops and forces the user to enter one.

If it's given dq/q or can calcualte one itself, it has no problem calulating qmin and qmax if neccessary.

Changeset: 5350c7c9ade812d0fff8c87d45b72d83d8d1a1d9

comment:2 Changed 7 years ago by Keith Brown

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester

Make sure all the features of the Reflectometry gui still work as per these docs.

To test his particular fix, Load a .tbl file then delete the entries in the qmin, qmax and dq/q columns. On INTER it should calculate them all automatically when process is pressed.

If possible test CRISP (grab any CRISP runs and put their run numbers into the run columns, along with a theta). If the CRISP data doesn't contain the required logs to calculate dq/q, it'll print an error to the log and not do anything else. If you give it a dq/q (such as 0.01) it'll be able to calculate qmin and qmax.

comment:3 Changed 7 years ago by Owen Arnold

  • Status changed from verify to verifying
  • Tester set to Owen Arnold

comment:4 Changed 7 years ago by Owen Arnold

For future reference on writing test instructions for reflectometry tickets, the Testing instructions http://www.mantidproject.org/Testing_ISIS_Reflectometry_GUI should stand-alone. No need to mention General usage instructions or Example. Also, the test instructions start talking about loading *.tbl files, but there's no link to the download of the data on the test page (I'll fix this)

comment:5 Changed 7 years ago by Keith Brown

  • Blocking 8883 added

(In #8883) Need to wait for #8887 as it may be that that ticket fixed this issue.

comment:6 Changed 7 years ago by Owen Arnold

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8887_refl_gui_dqq_qmin_qmax'

Full changeset: 80ab0fc39b79f178f756b09b0d3a290c8a56fac2

comment:7 Changed 7 years ago by Gesner Passos

  • Blocking 8921 added

comment:8 Changed 7 years ago by Gesner Passos

  • Blocking 8921 removed

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9731

Note: See TracTickets for help on using tickets.