Ticket #8902 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Fetching properties from non mandatory workspace

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 3.1
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

Causes ReflectometryReductionOneAuto algorithm to fall over.

Try this 

workspace_name = "POLREF4699"
workspace_nexus_file = workspace_name + ".nxs"
Load(workspace_nexus_file, OutputWorkspace=workspace_name)
ReflectometryReductionOneAuto(OutputWorkspace="Out", CorrectDetectorPositions=False, InputWorkspace=mtd[workspace_name][0], AnalysisMode='MultiDetectorAnalysis', ThetaIn=0.6, OutputWorkspaceWavelength='y')

Fails because NoneType has no getNumberHistograms()

This is because it's trying to use the transmission runs, which are not mandatory.

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Status changed from new to inprogress

comment:2 Changed 7 years ago by Owen Arnold

refs #8902. Fix input workspace usage.

Changeset: d4ca47ee31ded1116a106ea79178256388e34494

comment:3 Changed 7 years ago by Owen Arnold

Tester: Re-run the original script. You should get no errors this time. I've re-run the appropriate system tests locally and get no errors. As this is a minor change (in terms of code), you might want to look at the one-line change to see what I've done. Hopefully you'll see that using the InputWorkspace property (which is mandatory) is a better strategy.

Last edited 7 years ago by Owen Arnold (previous) (diff)

comment:4 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:5 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:6 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/8902_input_workspace_fix'

Full changeset: ​c0425abaa243037cab7655d27ca4c91ae36837a8

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9745

Note: See TracTickets for help on using tickets.