Ticket #8911 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

MultiDataFitting

Reported by: Nick Draper Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.3
Component: GUI Keywords: SSC,2014,All
Cc: Blocked By: #8922
Blocking: #10473, #10474, #10476, #10477, #10478, #10479, #10493, #10576, #10578 Tester: Dan Nixon

Description

Multi data fitting gui using mockup at 

Mantid\Documents\Design\multifitting

notes from estimation 

have a mock-up already, need manipulation of fit results (e.g. fitting resulting fit values, exporting results)

Attachments

2014-11-07-115615_2480x1920_scrot.png​ (86.7 KB) - added by Dan Nixon 6 years ago.
UI issues

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Component changed from Framework to User Interface

comment:2 Changed 7 years ago by Nick Draper

  • Blocked By 8922 added

comment:3 Changed 7 years ago by Jose Borreguero

  • Owner set to Jose Borreguero

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:5 Changed 6 years ago by Nick Draper

  • Milestone changed from Release 3.2 to Release 3.3

comment:6 Changed 6 years ago by Nick Draper

  • Owner changed from Jose Borreguero to Roman Tolchenov

comment:7 Changed 6 years ago by Roman Tolchenov

  • Status changed from assigned to inprogress

Re #8911. QtProperties can have options that can be displayed.

Changeset: f83ff00aa3c1771240b8148684d0d0ac59ce5b94

comment:8 Changed 6 years ago by Roman Tolchenov

Re #8911. Added a custom interface for multi-fitting.

Changeset: fc8d3bcd8d34bd05ed12c08d82cc2a76f1c3a4d3

comment:9 Changed 6 years ago by Roman Tolchenov

Re #8911. Adding Global option to FunctionBrowser.

Changeset: 4dc6772e43f5427b324a4a6c97c8c10beed2c5b8

comment:10 Changed 6 years ago by Roman Tolchenov

Re #8911. Added editor for property options.

Changeset: ae55e0324c1ffc2f6614b2a73af5b550b0a44256

comment:11 Changed 6 years ago by Roman Tolchenov

Re #8911. Create the multidomain function.

Changeset: c8f8ad0a7fdca3e1761fe21b8efa990a7b69fa7e

comment:12 Changed 6 years ago by Roman Tolchenov

Re #8911. Fitting and plotting results.

Changeset: 789307f4d2d27e5d2467272eb80d564ff7995911

comment:13 Changed 6 years ago by Roman Tolchenov

Re #8911. Button editor for local parameters.

Changeset: b2696a8903d021ee9e324c69189e9ac30ae802ee

comment:14 Changed 6 years ago by Roman Tolchenov

Re #8911. Edit local parameters.

Changeset: 72c8506ee8918dcad990d34580d90eb9d4fc7488

comment:15 Changed 6 years ago by Roman Tolchenov

Re #8911. Setting local parameter values and ties.

Changeset: eaba8993ce7ef5a71b0f27f3c8f9e81d431beb86

comment:16 Changed 6 years ago by Roman Tolchenov

Re #8911. Fixing the builds.

Changeset: 03be3258de6d228f09dfcbfea64184c7c0d17f97

comment:17 Changed 6 years ago by Roman Tolchenov

Re #8911. Fixing an error.

Changeset: d1c26b374e4d9da3c28166677f0b90df7b7ff679

comment:18 Changed 6 years ago by Roman Tolchenov

Re #8911. Fixing doxygen warnings.

Changeset: bdef0411b7db11f4fe23b0eca9ced1f02bcf30ca

comment:19 Changed 6 years ago by Roman Tolchenov

Re #8911. Removed Cancel button from local values dialog.

Changeset: ec0a062e6f5c2a17493b8b06da0953898ec3e10b

comment:20 Changed 6 years ago by Roman Tolchenov

Re #8911. Use AlgorithmRunner to run Fit.

Changeset: 52c5888b9e93c3cf2f73093d312b00b31b61e1e7

comment:21 Changed 6 years ago by Roman Tolchenov

Re #8911. Update parameters after Fit.

Changeset: 4085804f7dfebf251dac62ff499d7e4267460bf2

comment:22 Changed 6 years ago by Roman Tolchenov

Re #8911. Added zooming tools.

Changeset: 82b6ac5797e54dc108fc6a708fdc3e55d3733484

comment:23 Changed 6 years ago by Roman Tolchenov

Re #8911. Removed the progress bar.

Changeset: bb3087d3f0f4157b1936f6ae4367ffa49aa8da4c

comment:24 Changed 6 years ago by Roman Tolchenov

Re #8911. Tooltips and info display.

Changeset: 817d3de1c296670f82b01379926a3c09ba470891

comment:25 Changed 6 years ago by Roman Tolchenov

Re #8911. Handle cases of missing data.

Changeset: 206edc1697b22948cbeab3e9ae91852069c7d8b1

comment:26 Changed 6 years ago by Roman Tolchenov

Re #8911. Added the ... to the local parameter edit button.

Changeset: f6a001cd00ca7afe6ee159341ea5c8d06b9a1427

comment:27 Changed 6 years ago by Roman Tolchenov

  • Blocking 10473, 10474 added

comment:28 Changed 6 years ago by Roman Tolchenov

Re #8911. Fix compiler warning

Changeset: 67f694a8614ac6aa551877832a5dbb54a8739e40

comment:29 Changed 6 years ago by Roman Tolchenov

  • Blocking 10476 added

comment:30 Changed 6 years ago by Roman Tolchenov

  • Blocking 10477 added

comment:31 Changed 6 years ago by Roman Tolchenov

  • Blocking 10478 added

comment:32 Changed 6 years ago by Roman Tolchenov

  • Blocking 10479 added

comment:33 Changed 6 years ago by Roman Tolchenov

To tester

  1. Load a workspace with similar looking data (eg a musr set from autotest data). The data may need rebinning as there is no fitting range setting in the interface yet.
  2. Start the interface: Interfaces->General->Multi dataset fitting.
  3. Add a few spectra, not too many (~10)
  4. Define a function. Set some parameters global others leave local.
  5. Run a fit. See that there is correct output.
  6. Try setting different initial values, ties, constraints.
  7. Play with the plots, zooming, panning, etc.

comment:34 Changed 6 years ago by Roman Tolchenov

Re #8911. Changed interface's base class in qt designer.

Changeset: a713f826697f5814e2cfceef80e247aeabc6b465

comment:35 Changed 6 years ago by Roman Tolchenov

Re #8911. Increased FunctionBrowser's parameter precision to 6.

Changeset: 2a5383e3a9468cdffac93fb1680c7e05fe8e76bb

comment:36 Changed 6 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:37 Changed 6 years ago by Roman Tolchenov

  • Blocking 10493 added

comment:38 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester set to Dan Nixon

Changed 6 years ago by Dan Nixon

UI issues

comment:39 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to reopened
  • Resolution fixed deleted

See attachment to understand exactly what I mean, but on Ubuntu I cannot see the icons for the pan and zoom tools and the Global checkboxes fill the entire column.

Other than these points the actual functionality seems to work fine.

comment:40 Changed 6 years ago by Roman Tolchenov

  • Status changed from reopened to inprogress

Re #8911. Renamed the resource file name.

It looks like resource file names must be unique within application. Explicitly set the width of the checkbox in Global section of the function browser.

Changeset: d93561a6c009cfaa7fa439d1c6143e14f70bccf2

comment:41 Changed 6 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:42 Changed 6 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester changed from Dan Nixon to Wenduo Zhou

comment:43 Changed 6 years ago by Wenduo Zhou

  • Status changed from verifying to reopened
  • Resolution fixed deleted

I tried the multiDataFit interface. One issue that I found (or I did not know how to use) is that I could not define the fitting range. Thus I couldn't fit one peak in a multiple peaks pattern.

comment:44 Changed 6 years ago by Roman Tolchenov

  • Status changed from reopened to verify
  • Resolution set to fixed

Defining fitting ranges will be addressed in #10474. Please rebin the test data to required intervals before using the interface.

comment:45 Changed 6 years ago by Dan Nixon

  • Status changed from verify to verifying
  • Tester changed from Wenduo Zhou to Dan Nixon

comment:46 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge branch 'master' into feature/8911_multi_data_fititng

Full changeset: ​949a0fb4148a5bccf84be891b875c5432374e6fd

comment:47 Changed 6 years ago by Dan Nixon

Merge remote-tracking branch 'origin/feature/8911_multi_data_fititng'

Full changeset: ​089d930b72a6f4470aeb07b842e10ef567ebc9c6

comment:48 Changed 6 years ago by Dan Nixon

A couple of small things that could easily be done in an additional ticket:

  • It would be nice to have a way to set an initial value for a parameter for all spectra
  • The columns in the property browser should be able to be resized

comment:49 Changed 6 years ago by Roman Tolchenov

  • Blocking 10576 added

comment:50 Changed 6 years ago by Roman Tolchenov

  • Blocking 10578 added

comment:51 Changed 6 years ago by Nick Draper

  • Keywords SSC,2014,All added; SSC removed

comment:52 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9754

Note: See TracTickets for help on using tickets.