Ticket #8922 (closed: fixed)
Load performance History
| Reported by: | Nick Draper | Owned by: | Samuel Jackson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.2 |
| Component: | Framework | Keywords: | SSC,2014,All |
| Cc: | Blocked By: | #8913 | |
| Blocking: | #8911, #9369 | Tester: | Roman Tolchenov |
Description (last modified by Samuel Jackson) (diff)
Modify load/save functions on WorkspaceHistory to store the nested history records. Performance improvements will be handled in ticket #9450, most probably by switching to the HDF5 API instead of NeXus.
This ticket is just about getting correct loading and saving of algorithm history using our existing implementation.
Attachments
Change History
comment:2 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state
comment:5 Changed 6 years ago by Samuel Jackson
- Status changed from assigned to inprogress
Refs #8922 Add support for nested history saving.
Changeset: a7f230e97eb4f5759d30caef2463eed9a4694d69
comment:6 Changed 6 years ago by Samuel Jackson
Refs #8922 Refactor history loading.
Changeset: 7685625d22a8033f08027c5eaa6bb5cd5be8cf57
comment:7 Changed 6 years ago by Samuel Jackson
Refs #8922 Add support for loading nested histories.
Changeset: c60223824f8503455463718992e4bc2ae1c7bc03
comment:8 Changed 6 years ago by Samuel Jackson
Refs #8922 Fix bug with WorkspaceProperty.
Should only give the workspace a temp name if we have a pointer to a workspace.
Changeset: 0ad1585dd68800c49e7a1d9b7b6c797ef3de3541
comment:9 Changed 6 years ago by Samuel Jackson
Refs #8922 Add unit tests for nested WorkspaceHistory loading.
Changeset: 120dc060f82866c8cff58a5f8acbb1f148750996
comment:10 Changed 6 years ago by Samuel Jackson
Refs #8922 Fix SaveNexus and SaveNexusProcessed to capture history.
SaveNexus and SaveNexusProcessed wouldn't append a record to the history. This commit fixes that issue and leaves a record on the input workspace so the result is that we get a complete history, but we lose the execution start time and duration.
Changeset: 60dfa90f2749cb5c31371c68a6aff8186dd13c43
comment:11 Changed 6 years ago by Samuel Jackson
Refs #8922 Fix unit tests.
Changeset: f9dc5b737ef7ee6c3f776a974159d633944b8c96
comment:12 Changed 6 years ago by Samuel Jackson
Refs #8922 Remove commented out code in LoadNexusProcessed
It looks like history was loaded here at some point in the past. May as well remove this while I'm here.
Changeset: a0496d22c835ad528a1f5b9a1bdbc880db5bb6a5
comment:13 Changed 6 years ago by Samuel Jackson
To Test
Nested algorithm history should now be saved/loaded from nexus files. To test this try running a data processor algorithm (use the attached script for an example). To check the structure is saved to file properly, open it using HDFView and look in the "process" folder. You should see the structure is correctly nested and numbered.
Specific use cases to check:
- Try saving using the generic Save algorithm
- Try saving using the SaveNexus algorithm
- Try saving using the SaveNexusProcessed algorithm.
- Try loading with the generic Load algorithm.
- Try loading with the LoadNexus algorithm.
- Try loading with the LoadNexusProcessed algorithm.
- Check that the option to ignore loading history still works.
Note that the history will not show up in the history GUI, but can be explored using the python API.
comment:14 Changed 6 years ago by Samuel Jackson
- Status changed from inprogress to verify
- Resolution set to fixed
comment:16 Changed 6 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:17 Changed 6 years ago by Roman Tolchenov
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8922_history_loading_performance'
Full changeset: 0318e400db649586f0497ad9f6e012651dfc33e2
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9765
