Ticket #8948 (closed: fixed)
Polarisation Corrections
| Reported by: | Owen Arnold | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.2 |
| Component: | Reflectometry | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #9840 | Tester: | Michael Reuter |
Description (last modified by Owen Arnold) (diff)
This should be implemented as a useable algorithm in Mantid.
Once this has been verified by instrument scientists, we can inject it into ReflectometryReductionOne
1 week
Change History
comment:2 Changed 7 years ago by Nick Draper
- Status changed from new to assigned
Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state
comment:3 Changed 6 years ago by Owen Arnold
- Status changed from assigned to inprogress
refs #8948. Algorithms components in place.
Usual TDD. Check that bad inputs are correctly identified.
Changeset: d9b7d2871eb952f71329faf5eb0e3df48dd01be2
comment:4 Changed 6 years ago by Owen Arnold
refs #8948. Unverified changes. Need proper tests for this.
Changeset: 7d307037667252357c9a802e0f7307b98f121542
comment:5 Changed 6 years ago by Owen Arnold
Tim has sent information on this new algorithm that should allow me to complete the work. Email sent 10th June by Tim.
comment:6 Changed 6 years ago by Owen Arnold
refs #8948. Validate input workspace.
Changeset: c46cc37f1390127153d68b09e7d00a119600c184
comment:8 Changed 6 years ago by Owen Arnold
refs #8948. Ready for rename.
Changeset: db5328b24d0fe1be8bca79592181be69bfc80754
comment:9 Changed 6 years ago by Owen Arnold
refs #8948. Rename to PolarizationCorrection.
Changeset: 3f6c5438ebf132fc79af1b0d6ac84b04c20908a0
comment:10 Changed 6 years ago by Owen Arnold
refs #8948. Fix unused var warning.
Changeset: ceda2ebf400a38c653b43ac0c6be7acdc6e20949
comment:11 Changed 6 years ago by Owen Arnold
- Description modified (diff)
- Summary changed from Polarisation Corrections in ReflectometryReductionOne to Polarisation Corrections
comment:12 Changed 6 years ago by Owen Arnold
Tester, at this stage, please just check that the unit tests are passing OK. There is no code dependent on this, and I have to take it to the instrument scientists to verify that the correction routines are behaving as expected.
comment:13 Changed 6 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
comment:14 Changed 6 years ago by Michael Reuter
This class is causing doxygen errors.
comment:15 Changed 6 years ago by Martyn Gigg
- Status changed from verify to reopened
- Resolution fixed deleted
There is also a failing system test: the parameter names do not follow the standard conventions: http://builds.mantidproject.org/job/develop_systemtests_rhel6/lastCompletedBuild/testReport/SystemTests/CodeConventions/Algorithms/
comment:16 Changed 6 years ago by Martyn Gigg
- Status changed from reopened to inprogress
comment:17 Changed 6 years ago by Martyn Gigg
Fix problems with parameter names conflicting with coding standards.
Refs #8948
Changeset: b0ec09e2a9aefb5e394a40fb17cb594680c9df2d
comment:18 Changed 6 years ago by Martyn Gigg
comment:19 Changed 6 years ago by Martyn Gigg
Really fix doxygen warnings.
Parameter names need to match in header/source Refs #8948
Changeset: c3e640722451196945b4d23edc8dd85dd3f56d11
comment:20 Changed 6 years ago by Martyn Gigg
- Owner changed from Owen Arnold to Martyn Gigg
- Status changed from inprogress to verify
- Resolution set to fixed
Minor issues fixed. It seemed a shame for the ticket to be kept back for those issues.
comment:21 Changed 6 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:22 Changed 6 years ago by Martyn Gigg
Remove spaces after inline math markup.
Refs #8948
Changeset: e1c04bd2439e6c6809c952e3e7fcec0662cfb6ad
comment:23 Changed 6 years ago by Michael Reuter
- Status changed from verifying to closed
Merge remote branch 'origin/feature/8948_polarisation_corrections'
Full changeset: 34d1f94cee21bdb48449d9754940f007aa9d319e
comment:25 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9791
