Ticket #8961 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

SaveReflThreeCol save Algorithm

Reported by: Keith Brown Owned by: Lottie Greenwood
Priority: major Milestone: Release 3.3
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: #8963 Tester: John Hill

Description (last modified by Owen Arnold) (diff)

Reflectometry 3-Column is a file format the ISIS reflectometry gui could in theory save to, but at present it's not implemented

Write a c++ algorithm for it.

​https://github.com/mantidproject/mantid/blob/master/Code/Mantid/scripts/Reflectometry/isis_reflectometry/saveModule.py

Change History

comment:1 Changed 7 years ago by Keith Brown

  • Blocking 8963 added

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:3 Changed 6 years ago by Keith Brown

  • Milestone changed from Release 3.2 to Release 3.3

comment:4 Changed 6 years ago by Keith Brown

  • Owner changed from Keith Brown to Owen Arnold

not going to get this done before i leave, giving to owen

comment:5 Changed 6 years ago by Owen Arnold

  • Description modified (diff)

comment:6 Changed 6 years ago by Owen Arnold

  • Owner changed from Owen Arnold to Lottie Greenwood

Similar to #8959

comment:7 Changed 6 years ago by Lottie Greenwood

  • Status changed from assigned to inprogress

comment:8 Changed 6 years ago by Lottie Greenwood

Refs #8961 wrote threecolumn class

Changeset: aea62e9b3957824ac4df6b9c67b82a74cd5fe466

comment:9 Changed 6 years ago by Lottie Greenwood

Refs #8961 inc src file

Changeset: 29cb9023cec0290a1f3bb683f80a2e0108f450e7

comment:10 Changed 6 years ago by Lottie Greenwood

Refs #8961 inc testing file

Changeset: 4c2683c7246afce437afe6d87145aaac6c744c86

comment:11 Changed 6 years ago by Lottie Greenwood

Refs #8961 fully working save algorithm

Changeset: fd5d717e058b5294a90dfe290c2dd95ab52113cc

comment:12 Changed 6 years ago by Lottie Greenwood

Refs #8961 delete whitespace

Changeset: 51f0fa177cca51c3fec1b68cc9f4935529d00cc7

comment:13 Changed 6 years ago by Lottie Greenwood

Refs #8961 fixed for cppcheckbuilds

Changeset: 0e7283be98fbef9a1af0a89e093461732d2d882c

comment:14 Changed 6 years ago by Lottie Greenwood

Refs #8961 Fixed for cppCheck

Changeset: 2dd14f45163c4526dece79d4e70afdf3654e6094

comment:15 Changed 6 years ago by Lottie Greenwood

Refs #8961 Fixed for cppCheck1

Changeset: d4e9e1657d0f958b044b880aaeb8c0f77c1bf8e3

comment:16 Changed 6 years ago by Lottie Greenwood

Refs #8961 Fixed for cppcheckBuild

Changeset: fbe175b957bdb96f66c5748effb56e63be238b32

comment:17 Changed 6 years ago by Lottie Greenwood

refs #8961. Fix merge conflict with develop

Merge branch 'feature/8961_SaveReflThreeColumn_save_algorithm' into develop

Conflicts:

Code/Mantid/Framework/DataHandling/src/SaveReflCustomAscii.cpp

Changeset: 2a4c87b88bf5cf888cecadf7cf5545bb4f1e45de

comment:18 Changed 6 years ago by Lottie Greenwood

Refs #8961 Fixed unit test working

Changeset: 44012231081a2ac501a7b9cdd86c21bb86b70443

comment:19 Changed 6 years ago by Lottie Greenwood

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:20 Changed 6 years ago by Lottie Greenwood

To test:

  • Interfaces > Reflectometry > ISIS Reflectometry > Enter Runs = 13460 > Process
  • Run SaveReflThreeColumn Ascii, check returns 3 columns of x,y, e.

comment:21 Changed 6 years ago by John Hill

  • Status changed from verify to verifying
  • Tester set to John Hill

comment:22 Changed 6 years ago by John Hill

  • Status changed from verifying to reopened
  • Resolution fixed deleted

comment:23 Changed 6 years ago by Lottie Greenwood

  • Status changed from reopened to inprogress

Refs #8961 Fixes unused variable

Changeset: 283859b3a9404fdc1a6aca2bebd3f5fcc5301142

comment:24 Changed 6 years ago by Lottie Greenwood

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:25 Changed 6 years ago by John Hill

  • Status changed from verify to closed

Merge remote-tracking branch 'origin/feature/8961_SaveReflThreeColumn_save_algorithm'

Full changeset: ​cd424db7da66a0341e87662fe70a4545c7e06fae

comment:26 Changed 6 years ago by Martyn Gigg

Merge branch 'feature/8961_SaveReflThreeColumn_save_algorithm'

Full changeset: ​c25fecd54000eb083de669ad3851f80f1d9b0b61

comment:27 Changed 6 years ago by Lottie Greenwood

refs #8961. Fix merge conflict with develop

Merge branch 'feature/8961_SaveReflThreeColumn_save_algorithm' into develop

Conflicts:

Code/Mantid/Framework/DataHandling/src/SaveReflCustomAscii.cpp

Changeset: 2a4c87b88bf5cf888cecadf7cf5545bb4f1e45de

comment:28 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9804

Note: See TracTickets for help on using tickets.