Ticket #8997 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

cppcheck errors in InstrumentWindow code

Reported by: Martyn Gigg Owned by: Roman Tolchenov
Priority: critical Milestone: Release 3.2
Component: GUI Keywords: Maintenance
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

There are several cppcheck warnings in the instrument view code. See one of the latest jobs ​here

cppcheck is confused by the macro usage in GLActorVisitor & InstrumentActor. We discussed refactoring the code improve the readability and just use virtual functions that have a default implementation to avoid these issues.

It would be good to get this done in the maintenace period so that we can drive the cppcheck errors to zero.

Change History

comment:1 Changed 7 years ago by Martyn Gigg

  • Priority changed from major to critical

comment:2 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move of tickets out of triage (new) to assigned at the introduction of the triage state

comment:3 Changed 7 years ago by Roman Tolchenov

  • Status changed from assigned to inprogress

Re #8997. Removed macros. Changed c-style casts to static_casts

Changeset: 727d5926ddfef09f8f3127593b37c29a59e9640f

comment:4 Changed 7 years ago by Russell Taylor

Tons of GCC compiler warnings from this change.

comment:5 Changed 7 years ago by Roman Tolchenov

Re #8997. Fix gcc warnings

Changeset: e1fc6bcbdea9a35b4182a9649b9f63ad142961d2

comment:6 Changed 7 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test see the description.

comment:7 Changed 7 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:8 Changed 7 years ago by Martyn Gigg

There are currently quite a lot of compiler warnings on RHEL6 due to the changes here: ​http://download.mantidproject.org/jenkins/view/Develop%20Clean%20Builds%20and%20Tests/job/is_clean_rhel6_develop/372/warnings22Result/

comment:10 Changed 7 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/8997_cppcheck_errors_in_instrumentwindow'

Full changeset: ​fddd47e09455f0e77aa3e048d430d8ad6a724ee2

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9840

Note: See TracTickets for help on using tickets.