Ticket #8999 (closed: fixed)
SliceViewer crash
| Reported by: | Owen Arnold | Owned by: | Owen Arnold |
|---|---|---|---|
| Priority: | critical | Milestone: | Release 3.1.1 |
| Component: | Diffraction | Keywords: | PatchCandidate |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description
Peaks overlay in the slice viewer is crashing. Via the following.
Load(Filename='nx5841.nxs',OutputWorkspace='nx5841') md = ConvertToDiffractionMDWorkspace(InputWorkspace='nx5841',OutputWorkspace='md',OneEventPerBin='0') peaks =FindPeaksMD(InputWorkspace='md',MaxPeaks='10',OutputWorkspace='peaks') svw = plotSlice(md) sv = svw.getSlicer() sv.setPeaksWorkspaces(peaks)
Attachments
Change History
comment:2 Changed 7 years ago by Owen Arnold
- Status changed from new to inprogress
refs #8999. Don't use inst info if unfetchable.
Changeset: 2f0f4afb63b14dc5b3b06d73140465cb1fa4e98c
comment:3 Changed 7 years ago by Owen Arnold
This is a simple fix, in which the NotFoundException is deliberately swallowed. Running the script above should result in the SliceViewer being displayed.
comment:4 Changed 7 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
comment:6 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:7 Changed 7 years ago by Michael Reuter
- Status changed from verifying to reopened
- Resolution fixed deleted
I have a minor completeness issue with this one if this is going to be a patch candidate. The comment in the catch statement seems to be incomplete. It would be nice to get it finished.
comment:8 Changed 7 years ago by Owen Arnold
- Status changed from reopened to inprogress
Thanks for spotting this. I'll fix the comment.
comment:9 Changed 7 years ago by Owen Arnold
refs #8999. Better comment
Changeset: 34832ff98ff4a87fe7f399d82439dc19582cd845
comment:10 Changed 7 years ago by Owen Arnold
- Status changed from inprogress to verify
- Resolution set to fixed
comment:12 Changed 7 years ago by Michael Reuter
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/8999_slice_viewer_fix'
Full changeset: f67fb0881798ce73877162eccb6f875d6434fe3f
comment:13 Changed 7 years ago by Nick Draper
- Milestone changed from Release 3.2 to Release 3.1.1
Moved to patch release 3.1.1
comment:14 Changed 7 years ago by Owen Arnold
refs #8999. Don't use inst info if unfetchable.
Changeset: abd04b4cc45e6a8d45c73fa73911335aea690933
comment:15 Changed 7 years ago by Owen Arnold
refs #8999. Better comment
Changeset: e3cae6c5ea684f9ca257f449a4ac58cbb8fc7cd6
comment:16 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9842
This is because the SliceViewer is looking for InstrumentInfo, but this is sourced via the facilities xml file. Doesn't work if the IDF is fundamentally inside the nexus file.