Ticket #9021 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Remove ghost tubes from BASIS IDF

Reported by: Michael Reuter Owned by: Michael Reuter
Priority: major Milestone: Release 3.1.1
Component: Indirect Inelastic Keywords: PatchCandidate
Cc: Blocked By:
Blocking: Tester: Stuart Campbell

Description

It's been found that the ghost tubes can be removed from the IDF and therefore they don't show up in the instrument view. Make this happen. Need to check how reduction and mask files work in this new case.

Change History

comment:1 Changed 7 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 7 years ago by Michael Reuter

  • Status changed from assigned to inprogress

comment:3 Changed 7 years ago by Michael Reuter

Refs #9021. New system test reference file.

Changeset: c11a600f4a938ef2814b2bd00b825352529f677d

comment:4 Changed 7 years ago by Michael Reuter

Refs #9021. New IDF without ghost tubes.

Changeset: 04421d9478d8f427eb6f310d365afd810bbcaa66

comment:5 Changed 7 years ago by Michael Reuter

  • Status changed from inprogress to verify
  • Resolution set to fixed

The branch can be found ​here. There is also a systemtest branch ​here which needs to be merged first.

To test: Pass run 32264 through BASISReduction and see that the ghost tubes are no longer there. You can try manually running the BASISAutoReduction system test as well.

comment:6 Changed 7 years ago by Michael Reuter

  • Keywords PatchCandidate added

comment:7 Changed 7 years ago by Stuart Campbell

  • Status changed from verify to verifying
  • Tester set to Stuart Campbell

comment:8 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.2 to Release 3.1.1

Moved to patch release 3.1.1

comment:9 Changed 7 years ago by Stuart Campbell

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/9021_basis_ghost_removal'

Full changeset: ​616dbc741ae83d6703681476db32669fa351f210

comment:10 Changed 7 years ago by Stuart Campbell

Merge remote branch 'origin/feature/9021_basis_ghost_removal'

Full changeset: ​f5f22215fa743ed347e162e227a1b419939993f8

comment:11 Changed 7 years ago by Stuart Campbell

Looks good to me - and the system test passes.

Have left the branch on github to make it easier for Russell.

comment:12 Changed 7 years ago by Michael Reuter

Refs #9021. New system test reference file.

Changeset: 73c0a8d282ec75511f218f377e26101ff64670f3

comment:13 Changed 7 years ago by Michael Reuter

Refs #9021. New IDF without ghost tubes.

Changeset: 2ecb1b4db56c81a3a1c143fdb16735eb5a2137c4

comment:14 Changed 7 years ago by Russell Taylor

The commits in above are from cherry-picking the changes over to the patch release branch.

comment:15 Changed 7 years ago by Nick Draper

  • type changed from task to enhancement

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9864

Note: See TracTickets for help on using tickets.