Ticket #9040 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Inter Parameter file Update

Reported by: Owen Arnold Owned by: Owen Arnold
Priority: critical Milestone: Release 3.1.1
Component: Reflectometry Keywords: PatchCandidate
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

Email from Max.

7. I found a mistake in the INTER IDF, which is probably my fault: the
positions of slits 1 and 2 are wrong. They should be 14.801 and 16.724
(according to the last survey):


  <component type="slit" name="slit1">
    <location z="14.801"/>
     <!-- This log file stores the vertical opening of slit -->
    <parameter name="vertical gap">
      <logfile id="S1_VG" extract-single-value-as="last_value" />
    </parameter>
    <parameter name="y">
      <logfile id="S1_VG" eq="-value*0.001/2.0"
extract-single-value-as="last_value" />
    </parameter>

    <parameter name="y2">
      <logfile id="S1_VG" eq="0.3+value*0.001/2.0"
extract-single-value-as="last_value" />
    </parameter>
    <location z="15.250" y="0.3"/>
    </component>

  <component type="slit" name="slit2">
    <location z="16.724"/>
    <!-- This log file stores the vertical opening of this. Note this
     slit can also be translated in the z. However this info not stored
     in log file since it is not used in the data analysis process. -->
    <parameter name="vertical gap">
      <logfile id="S2_VG" extract-single-value-as="last_value" />
    </parameter>
  </component>

Change History

comment:1 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 7 years ago by Owen Arnold

I haven't had time to fix this yet, but it should make any incremental patch release made after the major 3.1 release!!

comment:3 Changed 7 years ago by Owen Arnold

  • Status changed from assigned to inprogress

refs #9040. INTER IDF updated.

Only the slit z positions have been updated. Everything else should be the same.

Changeset: a454ad1da81c1cecb5aa5c14c08d68a5607b579c

comment:4 Changed 7 years ago by Owen Arnold

Tester. The following python script shows that the new slit positions are being utilised. The script should print out the z-positions listed in the description.

import os
instrument_dir = config['instrumentDefinition.directory']
ws = LoadEmptyInstrument(Filename=os.path.join(instrument_dir, "INTER_Definition.xml"))
instrument = ws.getInstrument()
slit1 = instrument.getComponentByName("slit1")
print slit1.getPos().getZ()
slit2 = instrument.getComponentByName("slit2")
print slit2.getPos().getZ()

comment:5 Changed 7 years ago by Owen Arnold

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:6 Changed 7 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:7 Changed 7 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9040_inter_parameter_updates'

Full changeset: 6a41ad6182d5e9cb47ec975466adb4acdcc1ee80

comment:8 Changed 7 years ago by Anders Markvardsen

Numbers printed out where 14.801 16.724

comment:9 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.2 to Release 3.1.1

Moved to patch release 3.1.1

comment:10 Changed 7 years ago by Owen Arnold

refs #9040. INTER IDF updated.

Only the slit z positions have been updated. Everything else should be the same.

Changeset: 371ff0904aa6ba00cb16e20443ebae8d38e8f194

comment:11 Changed 7 years ago by Russell Taylor

The commit in comment:10 is the cherry-picked one into the patch release branch.

comment:12 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9883

Note: See TracTickets for help on using tickets.