Ticket #9049 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Clean up #includes some of the remote job submission files

Reported by: Ross Miller Owned by: Ross Miller
Priority: minor Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

Replace #includes with forward declarations where we can.

Change History

comment:1 Changed 7 years ago by Russell Taylor

  • Status changed from new to assigned

comment:2 Changed 7 years ago by Ross Miller

  • Keywords PatchCandidate added
  • Status changed from assigned to inprogress

comment:3 Changed 7 years ago by Ross Miller

Clean up unnecessary #includes from RemoteJobManager.h

Refs #9049

Changeset: 22229a3e84c80d4776aadc3ad30b84f5faeaf8ac

comment:4 Changed 7 years ago by Russell Taylor

  • Keywords PatchCandidate removed

Hi Ross - we don't consider things that don't benefit the end user for patch releases. Notice that the criteria were 'highly important [to users]' AND 'low risk'. Of course, this is worth doing though...

comment:5 Changed 7 years ago by Ross Miller

  • Status changed from inprogress to verify
  • Resolution set to fixed

Turns out there was only one header file to clean up. Marking the ticket fixed.

comment:6 Changed 7 years ago by Russell Taylor

  • Milestone changed from Backlog to Release 3.2

comment:7 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:8 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to reopened
  • Resolution fixed deleted

You should be able to also forward declare HTTPClientSession & HTTPRequest if you move all method definitions into the cpp file, which is the right thing to do anyway. Also, it would be good to see the m_session & m_displayName variables initialized in a constructor initialization list rather than the body.

comment:9 Changed 7 years ago by Ross Miller

  • Status changed from reopened to inprogress

More #include cleanups

Moved a few inlined functions over to the .cpp file which let me replace two more #includes with forward declarations.

Also moved 2 member variable initializations out of the constructor's body and into the constructor initialization list.

Refs #9049

Changeset: 53e019e868fe00e66a2eb852e5ff5951b388d55b

comment:10 Changed 7 years ago by Ross Miller

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:11 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying

comment:12 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Sorry to be pedantic, but since it's the whole point of the ticket.....

Now that all method definitions are in the cpp, you can replace the <istream> include with <iosfwd>. I should have looked ahead and noticed that before. Also, in the cpp file you can lose the <fstream> include.

comment:13 Changed 7 years ago by Ross Miller

  • Status changed from reopened to inprogress

More #include cleanups in RemoteJobManager.<h|cpp>

Replace <istream> with <iosfwd> Remove unneeded <fstream>

Refs #9049

Changeset: 8de998ddeec02044ffdcbdfcdc2810c1f841f94b

comment:14 Changed 7 years ago by Ross Miller

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:15 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying

comment:16 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/9049_remote_job_includes'

Full changeset: ​eb6a6ae77d1a3ecd29e23c3de855e189c8c2eb22

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9892

Note: See TracTickets for help on using tickets.