Ticket #9078 (closed: fixed)
Fitting IkedaCarpenter on workspace in units of DeltaE fails
| Reported by: | Martyn Gigg | Owned by: | Martyn Gigg |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.1.1 |
| Component: | Framework | Keywords: | PatchCandidate |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description
To reproduce:
- Load MARIReduction.nxs file from the systemtests/AnalysisTests/ReferencesResults
- Run SumSpectra to collapse the results to a single spectrum
- Plot the results
- Open the fitting tool and add a the IkedaCarpenterPV peak function
- Click Fit
You'll see an error
efixed must be set for energy transfer calculation
Change History
comment:2 Changed 7 years ago by Martyn Gigg
- Status changed from assigned to inprogress
IFunction::convertValue now picks up Ei/efixed if they are set.
Refs #9078
Changeset: 3c64b6b6b6bb70245ba76c810fac27e8c0252464
comment:3 Changed 7 years ago by Martyn Gigg
Reduce copy-and-pasted code in IFunction.
Refs #9078
Changeset: ee04f7032189d99369eaf11a6bd025568dbc96fa
comment:4 Changed 7 years ago by Nick Draper
- Milestone changed from Release 3.2 to Release 3.1.1
Moved to patch release 3.1.1
comment:5 Changed 7 years ago by Martyn Gigg
- Status changed from inprogress to verify
- Resolution set to fixed
Branch: bugfix/9078_ifunction_units_with_efixed
Tester: Check the steps in the description before merging to make sure you understand the error. After the branch is merged the Fit should proceed without an error.
comment:6 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:7 Changed 7 years ago by Michael Reuter
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/9078_ifunction_units_with_efixed'
Full changeset: a47d29f0b83050e1e5992d82176a9650af1f5d5f
comment:8 Changed 7 years ago by Martyn Gigg
IFunction::convertValue now picks up Ei/efixed if they are set.
Refs #9078
Changeset: b1be5e567b7a2da2ebec9fa661310be5935e05d2
comment:9 Changed 7 years ago by Martyn Gigg
Reduce copy-and-pasted code in IFunction.
Refs #9078
Changeset: 609cfbd505a0837e1d0a15ecfee27aa0a4fcf768
comment:10 Changed 7 years ago by Russell Taylor
The above 2 commits result from taking this work over to the patch release branch.
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9921
