Ticket #9097 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

SANS Allow user to define a new source of calibration

Reported by: Gesner Passos Owned by: Peter Parker
Priority: major Milestone: Release 3.2
Component: SANS Keywords:
Cc: anders.markvardsen@…, peter.parker@… Blocked By:
Blocking: Tester: Roman Tolchenov

Description (last modified by Karl Palmen) (diff)

User request: 

Can we put something in the user file to say 
“use the calibration from this file here ..” 
which then gets applied to the SANS runs for  SAM & CAN ?
We may be having to  re-reduce a lot of data sets as we find ways 
to improve the calibration.

It will be just available through UserFile. A new syntax will be available 

TUBECALIBFILE =  file_path

Having this entry, the positions of the detector in the TUBECALIBFILE will replace the positions in the loaded workspace (this will be done before any movement).

Attachments

test_9097.py​ (2.3 KB) - added by Gesner Passos 7 years ago.

Change History

comment:1 Changed 7 years ago by Gesner Passos

Remember to update the documentation inside Mantid site.

comment:2 Changed 7 years ago by Gesner Passos

re #9097 Function to get path and suggest name for workspace

Changeset: 7486df4003a98ba7cd6d5b3e1e3a61bdb5b86f88

comment:3 Changed 7 years ago by Gesner Passos

re #9097: Extend ISISInstrument to support applying calibration

Changeset: 6396c3477bc5912e67eb7d07f958aa4c70355513

comment:4 Changed 7 years ago by Gesner Passos

re #9097: Extend UserFile to process Calibrate option

Changeset: 650eb8765558fbff113c49f59f087058f22abbbc

comment:5 Changed 7 years ago by Owen Arnold

  • Status changed from new to assigned

comment:6 Changed 7 years ago by Gesner Passos

  • Status changed from assigned to inprogress

comment:7 Changed 7 years ago by Gesner Passos

re #9097. Do not use reference to workspace directly

There is an issue with the fact that we copy singleton, it will be dealt in #8470. Till there, it is necessary to store the name of the workspace instead of its reference.

Changeset: f84c3fe9ae24126c77de818acdcc41b6e61a5160

comment:8 Changed 7 years ago by Gesner Passos

re #9097: Provides the monitor when loading can

Use the monitor method introduced in #8906 to avoid trying to find path for the monitors and also reloading it.

Changeset: 934c11d4f06e4496617b651bb92bde2c10364fdb

Changed 7 years ago by Gesner Passos

comment:9 Changed 7 years ago by Gesner Passos

  • Status changed from inprogress to verify
  • Resolution set to fixed

I have added the python script test_9097.py that checks the validity of this ticket. The script is commented to help you understand what it is testing, and the result expected.

It adds the TUBECALIBFILE to a MaskFile, checks that the reduction consider the new calibration file, run the reduction in single mode and batch mode to show that the results are the same. It then, uses a new MaskFile without the TUBECALIBFILE and shows that the result is different.

comment:10 Changed 7 years ago by Karl Palmen

  • Description modified (diff)

Reformatted user request to make it easier to read.

comment:11 Changed 7 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:12 Changed 7 years ago by Nick Draper

  • Owner changed from Gesner Passos to Peter Parker

Ownership handed over to Peter

comment:13 Changed 7 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9097_tube_calib_file'

Full changeset: ​871541d7f83f496f50f4de4944a04059bf8b68c6

comment:14 Changed 7 years ago by Peter Parker

[EDIT: Removed commit message meant for another ticket.]

Last edited 7 years ago by Peter Parker (previous) (diff)

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​9940

Note: See TracTickets for help on using tickets.