SCDCalibratePanels error

[Vickie Lynch]

Error message when tried to run SCDCalibratePanels in mantidplot:

SCDCalibratePanels started

Error in execution of algorithm SCDCalibratePanels:

Not a valid attribute name "SampleX"

[Vickie Lynch]

Refs #9108 add sample positions to attributes

Changeset: 817e8a585c273a2349df46e0eec3dea12afed015

[Vickie Lynch]

Test script:

Load(Filename='TOPAZ_3007.peaks',OutputWorkspace='TOPAZ_3007')
SCDCalibratePanels(PeakWorkspace='TOPAZ_3007',PanelGroups='SpecifyGroups',Grouping='26',a='14',b='19.300000000000001',c='8.5999999999999996',alpha='90',beta='105',gamma='90',useL0='0',usetimeOffset='0',usePanelWidth='0',usePanelHeight='0',usePanelPosition='0',usePanelOrientation='0',AllowSampleShift='1',DetCalFilename=r'/home/vel/mantid/Code/release/bin/topaz.detcal',ResultWorkspace='Result',QErrorWorkspace='QErrorResults')

[Vickie Lynch]

Only moves sample for group 1?

[Vickie Lynch]

Sample position is changed for all groups, but detector offsets are different for each group:

Load(Filename='TOPAZ_3007.peaks',OutputWorkspace='TOPAZ_3007')
SCDCalibratePanels(PeakWorkspace='TOPAZ_3007',a='14',b='19.300000000000001',c='8.5999999999999996',alpha='90',beta='105',gamma='90',useL0='0',usetimeOffset='0',usePanelWidth='0',usePanelHeight='0',usePanelOrientation='0',AllowSampleShift='1',PreProcFilename=r'/home/vel/mantid/Code/release/bin/topaz.detcal',DetCalFilename='topaz.detcal',ResultWorkspace='Result',QErrorWorkspace='QErrorResults')

[Peter Peterson]

Does the if statement at line 292 need to get changed to

if( SampleOffsets)
{
  SampOffsetDeclareStatus = 2;
}

Also, shouldn't the bit at line 435 always get the sample offsets, but not refine them?

[Vickie Lynch]

Hi Pete, For your last suggestion about sample offsets, do you want parameters added so the user can specify sample offsets?

[Peter Peterson]

I think that was always the intent. Otherwise the sample offsets would always have to be refined during the last step.

[Vickie Lynch]

Refs #9108 input parameters for sample offset

Changeset: f8fb67a6983423a1e03f253a288c364400a108ca

[Peter Peterson]

Merge remote branch 'origin/feature/9108_SCDCalibratePanels_error'

Full changeset: ​467886d402547cc64a049875cebeb8235938f9a4

[Owen Arnold]

These changes have caused the windows debug builds to fail. This relates to this changeset ​https://github.com/mantidproject/mantid/commit/f8fb67a6983423a1e03f253a288c364400a108ca see report here ​http://download.mantidproject.org/jenkins/view/Develop%20Clean%20Builds%20and%20Tests/job/is_clean_win7_develop_db/176/

[Stuart Campbell]

This ticket has been transferred to github issue ​9951