Ticket #9122 (closed: fixed)
SuggestTibCNCS has some typos
| Reported by: | Andrei Savici | Owned by: | Andrei Savici |
|---|---|---|---|
| Priority: | trivial | Milestone: | Release 3.2 |
| Component: | Direct Inelastic | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Michael Reuter |
Description
Prompt pulse is calculated wrongly (an extra 0 in the exponent). Also, try to check if one can get a TIB range just below prompt pulse, if the prompt pulse is inside the original TIB range (20 meV).
Change History
comment:4 Changed 7 years ago by Andrei Savici
- Status changed from assigned to inprogress
Small typos and fix for TIB at CNCS. Refs #9122
Changeset: 27106ae63c1f32aa556df7894a3adf64fa6d4a82
comment:5 Changed 7 years ago by Andrei Savici
- Status changed from inprogress to verify
- Resolution set to fixed
comment:6 Changed 7 years ago by Nick Draper
- Status changed from verify to verifying
- Tester set to Nick Draper
comment:7 Changed 7 years ago by Nick Draper
- Status changed from verifying to verify
- Tester Nick Draper deleted
Code review seems sensible, however the suggested test file is not in autotestdata or systemtest data so returning to the testing pool for someone at ORNL to pick up.
comment:8 Changed 7 years ago by Michael Reuter
- Status changed from verify to verifying
- Tester set to Michael Reuter
comment:9 Changed 7 years ago by Michael Reuter
- Status changed from verifying to reopened
- Resolution fixed deleted
Certain energies (~15 meV) look like they are picking up a fair amount of the prompt pulse. Also, the max range value seems to be 3400 rather than 3500. The wiki docs need updating if this is true.
comment:10 Changed 6 years ago by Andrei Savici
- Status changed from reopened to inprogress
New reference for new TIB range. Refs #9122
Changeset: 8862a77f44e0a15081d93166fade7b3933c7cee2
comment:11 Changed 6 years ago by Andrei Savici
Rewrite logic for finding TIB range. Refs #9122
Changeset: dcc2d4c53fcf18298a340060289cb0e0a20a947f
comment:12 Changed 6 years ago by Andrei Savici
- Status changed from inprogress to verify
- Resolution set to fixed
To tester: make sure you merge branches on mantid and on systemtest
comment:14 Changed 6 years ago by Michael Reuter
- Status changed from verifying to reopened
- Resolution fixed deleted
For 15 meV, the max on the suggested TIB range now includes the elastic line which I don't think is correct.
comment:15 Changed 6 years ago by Andrei Savici
- Status changed from reopened to inprogress
Increase pulse interval. Refs #9122
Changeset: caa3e5f3e59ddaa52cbe8e93c14d974385395904
comment:16 Changed 6 years ago by Andrei Savici
- Status changed from inprogress to verify
- Resolution set to fixed
Tester error, but improved prompt pulse avoidance. 15 meV run 77063
comment:18 Changed 6 years ago by Andrei Savici
Add comments and follow Mantid naming convention. Refs #9122
Changeset: fc1cab4161f44cbb877b99f392eacdb25075d880
comment:19 Changed 6 years ago by Andrei Savici
Mantid naming convention changes. Refs #9122
Changeset: 8a3827a2b5a4a140d92b7096df8f0d588e401c2f
comment:20 Changed 6 years ago by Michael Reuter
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/bugfix/9122_TIBCNCSfix'
Full changeset: 6695e0d46f3494b353711e6091b4593a68f0a557
comment:21 Changed 6 years ago by Michael Reuter
Merge remote-tracking branch 'origin/feature/9122_TIBCNCSfix'
Full changeset: b060ba3757015d9bcedb56fedd38d3d87e1eaa9b
comment:22 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 9965
To test, load CNCS run 76328, SumSpectra, Rebin with a step of 10. Plot the spectrum and see if the suggested TIB is OK. Try for other energies if you like.