Ticket #9133 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Allow more complex sample and source IDF descriptions

Reported by: Anders Markvardsen Owned by: Anders Markvardsen
Priority: major Milestone: Release 3.2
Component: Framework Keywords: core
Cc: pkwi@… Blocked By:
Blocking: #8957, #9237 Tester: Karl Palmen

Description

Currently IDF does not allow IDF sample and source descriptions which contain components, i.e. is an ensemble.

Attached is a McStas generated IDF where the sample and source descriptions are components of components. Loading this file is OK but when do Show Instrument Mantid dies

Bugfix and enhance Mantid to allow arbitrary complex structure for sample and source also

Attachments

templateSANS.out.xml (18.8 KB) - added by Anders Markvardsen 7 years ago.
mcstas generated idf
HRPD_Definition_mod.xml (82.0 KB) - added by Anders Markvardsen 7 years ago.
HRPD with complicated sample shape
HRPD_Definition_mod2.xml (88.9 KB) - added by Anders Markvardsen 7 years ago.
HRPD with complicated sample and source shape
ALF_Definition_with_source.xml (26.3 KB) - added by Anders Markvardsen 7 years ago.
ALF with complicated sample and source shape

Change History

Changed 7 years ago by Anders Markvardsen

mcstas generated idf

comment:1 Changed 7 years ago by Owen Arnold

  • Status changed from new to assigned

Sounds like a good enhancement to have.

comment:2 Changed 7 years ago by Anders Markvardsen

  • Status changed from assigned to inprogress

Make IDF parser submit assembly sample comp also. re #9133

And add unit test to test that this works

Changeset: 3c6f26cde381edaa2abc61422555db96747e982a

comment:3 Changed 7 years ago by Anders Markvardsen

store store as IComponent. re #9133

and added unit test to test ok

Changeset: 2db727fcf8ecb4e547c787aeabd3e92fcd80514f

comment:4 Changed 7 years ago by Martyn Gigg

Update the function signatures of the Python instrument export.

Refs #9133

Changeset: 89a731104bbedbb5a2ea13df8cc6461e3ec5bea2

comment:5 Changed 7 years ago by Anders Markvardsen

  • Blocking 9237 added

Changed 7 years ago by Anders Markvardsen

HRPD with complicated sample shape

Changed 7 years ago by Anders Markvardsen

HRPD with complicated sample and source shape

comment:6 Changed 7 years ago by Anders Markvardsen

  • Cc pkwi@… added

Changed 7 years ago by Anders Markvardsen

ALF with complicated sample and source shape

comment:7 Changed 7 years ago by Anders Markvardsen

Remove SampleActor from InstrumentActor. re #9133

As discussed with Roman if ever relevant can be added again

Changeset: 7fd3bd60b0df3f7708ee8f16c33e507d5912d20b

comment:8 Changed 7 years ago by Anders Markvardsen

Remove unused variable. re #9133

Changeset: fedc88c714efe8fe32f8c798a87fc169ab1fb0d8

comment:9 Changed 7 years ago by Anders Markvardsen

  • Status changed from inprogress to verify
  • Keywords core added
  • Resolution set to fixed

To test:

  1. check that unit tests are ok
  1. Load attached HRPD_Definition_mod.xml either using Load button or LoadEmptyInstrument and you should see some blob around the origin, which is some mcstas generated sample geometry
  1. Load attached HRPD_Definition_mod2.xml and/or ALF_Definition_with_source.xml, which should both display. Notice that when viewed in 3D view you will see instrument at a large distance because of the source description is far away from the rest of the instrument. we probably at some need to think about how we handle this better, but for now either zoom on sample or source to see some blob, or user Instrument tree to focus on these features

Note ignore the templateSANS.out.xml file which is ga ga

comment:10 Changed 7 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:11 Changed 7 years ago by Karl Palmen

In 2. I do not see a blob at the origin. If I view instrument tree, I see a nickel holder with 12 components. If a select the nickel holder I do see a blob at the origin also I see parts of this blob when I select a componenents of the nickel holder. This is what I'd expect from a sample that contains components.

comment:12 Changed 7 years ago by Karl Palmen

3 went as expected.

comment:13 Changed 7 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9133_idf_source_shape' into feature/9133_idf_source_shape

Full changeset: 881bb2a23ec590a6ce2653f97874b15b7e0be496

comment:14 Changed 7 years ago by Karl Palmen

Merge remote-tracking branch 'origin/feature/9133_idf_source_shape'

Full changeset: 5fcfd9663728e53bde1ca16df5189ac8b64a1644

comment:15 Changed 6 years ago by Anders Markvardsen

  • Blocking 8957 added

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 9976

Note: See TracTickets for help on using tickets.