Ticket #9168 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Enhancements around Transmission Runs

Reported by: Owen Arnold Owned by: Keith Brown
Priority: critical Milestone: Release 3.2
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description (last modified by Owen Arnold) (diff)

The following are important to get fixed for the next release.

Messages from user:

1) The transmission column in the table doesn't seem to accept a workspace, rather than one or more run numbers

2) A transmission workspace is created for every single line in the table. Originally there was a check whether the requested transmission run already existed, i.e. from the one or two run numbers given, a name is formed and that workspace remains in the list of workspaces for future use. Then, if the same run number(s) are encountered in the table, the already present trans workspace is used (rather than re-loading and generating the same one again).

Change History

comment:1 Changed 7 years ago by Owen Arnold

  • Description modified (diff)

comment:2 Changed 7 years ago by Owen Arnold

  • Status changed from new to assigned

comment:3 Changed 7 years ago by Keith Brown

  • Status changed from assigned to inprogress

refs #9168 Fixed pascal case noted in other ticket

In #9038 it was noted that there was some pascal case named varables and parameters knocking about, i've renamed those i could find

Changeset: d4927cb4e7ca53f793d472656e54c3198474fb9b

comment:4 Changed 7 years ago by Keith Brown

Refs #9168 transmission runs are now reused if possible

When processing in the gui, the gui will check the last transmission runs used and use the workspace from last time if it can.

The gui will accept workspace and file names for transmission runs.

Some instances of print have been changed to logger.debug

Changeset: d96a3e6969d9b52a35a931d4cbba5768b0e06419

comment:5 Changed 7 years ago by Keith Brown

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Tester

Set the Log to debug.

Load INTER_NR_test2.tbl into the interface and process it. Note that the 'trans' columns all contain the same run numbers.

In the log you should notice that "Creating new transmission correction workspace." appears once and "Using existing transmission workspace." appears three times. This shows that it is now creating the transmission correction workspace once, reusing it for the other runs that use the same transmission runs, then deleting it; rather than creating and deleting it four times.

Also try putting workspace and file names into the transmission runs column. Files don't need an extension and must be in your managed user directories.

comment:6 Changed 7 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:7 Changed 7 years ago by Anders Markvardsen

Hi Keith, could you attach a copy of INTER_NR_test2.tbl please?

comment:8 Changed 7 years ago by Keith Brown

It's in the ISIS sample data. http://download.mantidproject.org/download.psp?f=/SampleData/SampleData-ISIS.zip

I forgot to attach a link to http://www.mantidproject.org/ISIS_Reflectometry_Examples which would have mentioned that

comment:9 Changed 7 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9168_Refl_Transmission_Run_Enhance'

Full changeset: b4dbe7d1efb664e3e3b26e6b34ae4d5997752a23

comment:10 Changed 7 years ago by Anders Markvardsen

Log included entries: "Creating new transmission..."

comment:11 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10011

Note: See TracTickets for help on using tickets.