Crash when closing MuonAnalysis while on Data Analysis tab

[Arturs Bekasovs]

This was addressed before, but it seems that there still are circumstances when this crash happens:

1. Load and plot some data in MuonAnalysis.

2. Go to Data Analysis tab. Range selectors should appear on the graph.

3. Move the graph window, so that it is on top of the MuonAnalysis window.

4. Close MuonAnalysis.

[Arturs Bekasovs]

This happens due to that line:

  // When fit browser destroyed, disable oneself in the parent graph 
  connect(m_fitPropertyBrowser, SIGNAL( destroyed() ), graph, SLOT( disableTools() ), 
    Qt::QueuedConnection);

As the connection is queued, we sometimes end up in the state when m_fitPropertyBrowser was deleted, but the PeakPicker tool attached to it wasn't, because the disableTools() call is still in the queue. If we ask the graph to be re-plotted at that point (which happens when windows overlap), we get the crash.

[Owen Arnold]

Great detailed ticket information.

[Arturs Bekasovs]

Refs #9172. Make connection to disableTools() direct

This avoids the situation with fit browser being deleted, and the tool being not.

Changeset: 93c640fadaaec04c7f2942de5a6c6eb37bf08cb9

[Arturs Bekasovs]

Tester:

Make sure this doesn't happen any more. Closing the MuonAnalysis while on Data Analysis tab should cause range selectors on the graph to disappear.

NB: This relates to Fit Browser in MuonAnalysis only, as it is impossible to destroy the main Fit Browser, it can only be hidden.

[Jay Rainey]

The crash no longer occurs. This change only effects MuonAnalysis as noted by Arthurs in comment:4. To be safe, I tested plotting in various other interfaces to ensure this change did not inadvertently break anything. All is well.

[Jay Rainey]

Merge remote-tracking branch 'origin/bugfix/9172_muon_close_on_da_tab_crash'

Full changeset: ​5dfc59db85cae37d4b77f6ef0947f49b31742809

[Stuart Campbell]

This ticket has been transferred to github issue ​10014