Ticket #9192 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

LoadIsawPeaks should apply DetCal info in file

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Russell Taylor

Description

There is DetCal info stored in the ISAW peaks file. Currently this is skipped in LoadIsawPeaks, but should be applied to the instrument.

Change History

comment:1 Changed 7 years ago by Vickie Lynch

Ruth did this in ticket 5487 in ApplyCalibInfo. I checked that LoadIsawDetCal makes the same changes as what Ruth did. The reason I thought this was not done was that the DSpacing and Q vectors are different from the original after SaveIsawPeaks and LoadIsawPeaks. Maybe the Save is causing the difference.

comment:2 Changed 7 years ago by Vickie Lynch

Noticed that show detectors had multiple pixels before save and only one after. Tried commenting the extra pixels in FindPeadsMD line 111, but the peaksworkspaces were still different.

comment:3 Changed 7 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:4 Changed 7 years ago by Vickie Lynch

  • Status changed from assigned to inprogress

Refs #9192 Found why Q and DSpacing are different after LoadIsawPeaks

Changeset: c66697134d3385fe44b2d832abd6a7c7f82fb3ba

comment:5 Changed 7 years ago by Vickie Lynch

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test check that both peaks workspaces have the same dSpacing and Q vectors. 

Load(Filename='TOPAZ_6251_event.nxs',OutputWorkspace='TOPAZ_6251_event',LoadMonitors='1')
ConvertToMD(InputWorkspace='TOPAZ_6251_event',OutputWorkspace='TOPAZ_6251_md',QDimensions='Q3D',dEAnalysisMode='Elastic',Q3DFrames='Q_sample',MinValues='-25,-25,-25',MaxValues='25,25,25',SplitInto='2',SplitThreshold='50',MaxRecursionDepth='13',MinRecursionDepth='7')
FindPeaksMD(InputWorkspace='TOPAZ_6251_md',PeakDistanceThreshold='0.37680000000000002',MaxPeaks='50',DensityThresholdFactor='100',OutputWorkspace='TOPAZ_6251_peaks')
FindUBUsingFFT(PeaksWorkspace='TOPAZ_6251_peaks',MinD='3',MaxD='15',Tolerance='0.12')
SelectCellWithForm(PeaksWorkspace='TOPAZ_6251_peaks',FormNumber='9',Apply='1')
LoadIsawPeaks(Filename=r'/home/vel/workspace/TOPAZ_6251.peaks',OutputWorkspace='peaks_read')

comment:6 Changed 7 years ago by Vickie Lynch

  • Status changed from verify to reopened
  • Resolution fixed deleted

ReduceOne SCD system test fails

comment:7 Changed 7 years ago by Vickie Lynch

  • Status changed from reopened to inprogress

Refs #9192 update reference file

Changeset: ab35b37dfa1b4172456fdc8ef3ece155aa3b2b14

comment:8 Changed 7 years ago by Vickie Lynch

  • Status changed from inprogress to verify
  • Resolution set to fixed

feature/9192_LoadIsawPeaks_DetCal in both system test and mantid must be merged

comment:9 Changed 7 years ago by Russell Taylor

  • Status changed from verify to verifying
  • Tester set to Russell Taylor

comment:10 Changed 7 years ago by Russell Taylor

  • Status changed from verifying to closed

Merge remote branch 'origin/feature/9192_LoadIsawPeaks_DetCal'

Full changeset: ​5edaf9e33d6e9b6a73ad1c312fa5db45b8af362f

comment:11 Changed 7 years ago by Russell Taylor

Merge remote branch 'origin/feature/9192_LoadIsawPeaks_DetCal'

Full changeset: ​a74eda05a63e04b1b0105603d455603d7da70249

comment:12 Changed 7 years ago by Russell Taylor

I can still see very small differences, particularly in QSample but the number are much, much closer than before.

comment:13 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10035

Note: See TracTickets for help on using tickets.