Ticket #9198 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

IDA ConvFit: Add support for DiffSphere and DiffRotDiscreteCircle

Reported by: Samuel Jackson Owned by: Dan Nixon
Priority: critical Milestone: Release 3.4
Component: Indirect Inelastic Keywords:
Cc: Blocked By: #10189, #11447
Blocking: Tester: Raquel Alvarez

Description (last modified by Samuel Jackson) (diff)

There's a function called DiffSphere which some of the Indirect scientists would be keen to have exposed on the ConvFit interface. It should be added as part of the composite passed as a member of the Convolution.

This requires adding an additional parameter to the fit for the centre of the peak. People to talk to about this are Roman and Jose.

Change History

comment:1 Changed 7 years ago by Samuel Jackson

Discussed this with Jose. It will require a small modification to pass an additional 'centre' parameter to DiffSphere.

Last edited 7 years ago by Samuel Jackson (previous) (diff)

comment:2 Changed 7 years ago by Owen Arnold

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Samuel Jackson

  • Description modified (diff)

comment:4 Changed 6 years ago by Nick Draper

  • Owner changed from Samuel Jackson to Dan Nixon

comment:5 Changed 6 years ago by Jose Borreguero

  • Blocked By 10189 added

comment:6 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Added DiffSphere option to conv fit

Only works with single fit, does not use Q param yet

Refs #9198

Changeset: ead902d9bdaad94b30c77dcc8f270a5445ee9234

comment:7 Changed 6 years ago by Dan Nixon

Merge branch 'master' into 9198_add_diffsphere_support_to_convfit

Refs #9198

Changeset: 62af761f23a6d93f20a3a3fe1222314179f82a93

comment:8 Changed 6 years ago by Dan Nixon

Add the Shift parameter into the ConvFit UI

Refs #9198

Changeset: 6ce8da18400a50b4cd9b1d24d331239e2bbe8d99

comment:9 Changed 6 years ago by Dan Nixon

Document the function in COnvFit

Refs #9198

Changeset: 3bfd29b9f3cc2bf9861a34dac72b205520195d3a

comment:10 Changed 6 years ago by Dan Nixon

  • Summary changed from IDA ConvFit: Add support for DiffSphere. to IDA ConvFit: Add support for DiffSphere and DiffRotDiscreteCircle

comment:11 Changed 6 years ago by Dan Nixon

  • Blocked By 11447 added

comment:12 Changed 6 years ago by Dan Nixon

Merge branch 'master' into 9198_add_diffsphere_support_to_convfit

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectDataAnalysis.py

Refs #9198

Changeset: f6e26c4ef7e1f81f01ca3d4d1932b0bfe1ff3a87

comment:13 Changed 6 years ago by Dan Nixon

Added support for DiffRotDiscreteCircle

Refs #9198

Changeset: afcfe774f4eadf80066191bd1663c8f2cea3f93d

comment:14 Changed 6 years ago by Dan Nixon

Merge branch 'master' into 9198_add_diffsphere_support_to_convfit

Refs #9198

Changeset: b0aab1c4b7c22f8dd2d9c8c2382b896d2c87fff5

comment:15 Changed 6 years ago by Dan Nixon

Create correct param workspaces in script

Refs #9198

Changeset: 99440c83edf5ab2f61a126c21c18d5cd75c080f7

comment:16 Changed 6 years ago by Dan Nixon

Support proper plot options on UI

Refs #9198

Changeset: a293d2f568b321e3028fa10b244c407bee098895

comment:17 Changed 6 years ago by Dan Nixon

  • Milestone changed from Backlog to Release 3.4

comment:18 Changed 6 years ago by Dan Nixon

  • Priority changed from major to critical

comment:19 Changed 6 years ago by Dan Nixon

Merge branch 'master' into 9198_add_diffsphere_support_to_convfit

Refs #9198

Changeset: 38d509a88c6ab585eceaab6281a5cf73bb2ca756

comment:20 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as pull request #540.

comment:21 Changed 6 years ago by Dan Nixon

Update documentation Refs #9198

Changeset: 4a022cd3314372fea4b610e011bb7f9073034f59

comment:22 Changed 6 years ago by Dan Nixon

Load the resolution file in tests

Refs #9198

Changeset: 6bf5453d1498ef95fd040857c46c7a852788a555

comment:23 Changed 6 years ago by Dan Nixon

Fix issue with PlotPeakByLogValue and workspace index param

Refs #9198

Changeset: e1f827989f5f910358697d2f17b67155582ee271

comment:24 Changed 6 years ago by Raquel Alvarez

  • Status changed from verify to verifying
  • Tester set to Raquel Alvarez

comment:25 Changed 6 years ago by Raquel Alvarez

  • Status changed from verifying to closed

Merge pull request #540 from mantidproject/9198_add_diffsphere_support_to_convfit

Add DiffSphere support to IDA ConvFit

Full changeset: bd441134281c299091e0dcae265987748d6a3bb1

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10041

Note: See TracTickets for help on using tickets.