Ticket #9199 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Improvements to MultiDomainFunction

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #5121 Tester: Samuel Jackson

Description (last modified by Roman Tolchenov) (diff)

  1. Fit should generate output workspaces if CreateOutput is true.
  2. setWorkspace() and setMatrixWorkspace() methods must be called on domain creation in Fit.

Attachments

test_output.py​ (757 bytes) - added by Roman Tolchenov 7 years ago.

Change History

comment:1 Changed 7 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 7 years ago by Roman Tolchenov

  • Status changed from assigned to inprogress

Re #9199. A bit of refactoring of MultiDomainFunction and M-D-Creator.

Changeset: 50e1fe8365786df2c8c653eca045fdba4b82eae7

comment:3 Changed 7 years ago by Roman Tolchenov

Re #9199. Implement iterationStarting() method on M-D-Function

Changeset: 3dc8d09cd9fc9a97108a9e268ca9e4d00135c536

comment:4 Changed 7 years ago by Roman Tolchenov

Re #9199. MultiDomainCreator creates output workspace

Changeset: 589e466d5ed8e0ea09b7cf194745d9a494436277

comment:5 Changed 7 years ago by Roman Tolchenov

Re #9199. Added a unit test

Changeset: 2d6008ad2772675a3336fad7a17671e62402ded4

comment:6 Changed 7 years ago by Roman Tolchenov

  • Description modified (diff)

Changed 7 years ago by Roman Tolchenov

comment:7 Changed 7 years ago by Roman Tolchenov

Re #9199. Added another unit test

Changeset: 4381a65df3064e3291762f2ef93c80e55c7223c6

comment:8 Changed 7 years ago by Roman Tolchenov

Re #9199. Fixing the builds.

Changeset: 13ee21a6e2ea5a0e67d8fe5b27a21383a5c77f06

comment:9 Changed 7 years ago by Roman Tolchenov

Re #9199. Changes in MDEvents

Changeset: 7dc6e57b87bae3e8027d0c8f589f4a8d65b03117

comment:10 Changed 7 years ago by Martyn Gigg

There are some compiler warnings in MultiDomainCreator and the tests. See ​here

comment:11 Changed 7 years ago by Roman Tolchenov

Re #9199. Fixing compiler warnings

Changeset: ebedfb04839d24ff0908514f0f024ec329d497e9

comment:12 Changed 7 years ago by Samuel Jackson

  • Blocking 5121 added

comment:13 Changed 7 years ago by Roman Tolchenov

Re #9199. A bit of refactoring of MultiDomainFunction and M-D-Creator.

Changeset: 40e59eb05d65ba1113ab98619a54a4b7330cbe08

comment:14 Changed 7 years ago by Roman Tolchenov

Re #9199. Implement iterationStarting() method on M-D-Function

Changeset: 06c77eea33cb77ba3f78dd903218cceaaf78178e

comment:15 Changed 7 years ago by Roman Tolchenov

Re #9199. MultiDomainCreator creates output workspace

Changeset: 0f7b988d1342d15747f437ca2257f3d444677fed

comment:16 Changed 7 years ago by Roman Tolchenov

Re #9199. Added a unit test

Changeset: 1de4ae2ebae5bd63633347ab478b0ae1f9a65ed5

comment:17 Changed 7 years ago by Roman Tolchenov

Re #9199. Added another unit test

Changeset: 0389a70a5436b6d60f10f9526a6fe6d81db418da

comment:18 Changed 7 years ago by Roman Tolchenov

Re #9199. Fixing the builds.

Changeset: 2d563c2f257d18a7d70e30c10265233bfee73a79

comment:19 Changed 7 years ago by Roman Tolchenov

Re #9199. Changes in MDEvents

Changeset: 0fd8a20ef7c537ce2cc87c76629a3cc561e0ce34

comment:20 Changed 7 years ago by Roman Tolchenov

Re #9199. Fixing compiler warnings

Changeset: 7035e47a5af7914feb35bb32ca23823756ed77c7

comment:21 Changed 7 years ago by Roman Tolchenov

Re #9199. Testing that setWorkspace is called.

Changeset: e68da27b45775bedeb4009ad7350f3d908fd861d

comment:22 Changed 7 years ago by Roman Tolchenov

Merge branch 'feature/9199_multidomain_improvements' into develop

Conflicts:

Code/Mantid/Framework/CurveFitting/test/MultiDomainCreatorTest.h

Re #9199

Changeset: ad5615a20e2195d77a9495e64732b89299b24f2f

comment:23 Changed 7 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test

  • Run the attached scripts and check the output.
  • Code review.

comment:24 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:25 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Group name for the output workspace should really be consistent with the group output from PlotPeakByLogValue, one or the other should change. Apart from that it looks good.

comment:26 Changed 7 years ago by Roman Tolchenov

  • Status changed from reopened to inprogress

Re #9199. Changed names of the output workspaces

Changeset: 234ef736d9b726ad0230285fe769bf6f2ced0962

comment:27 Changed 7 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:28 Changed 7 years ago by Samuel Jackson

  • Status changed from verify to verifying

comment:29 Changed 7 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9199_multidomain_improvements'

Full changeset: ​bd71dbe53eb61802a38f7c22577a91d44095b631

comment:30 Changed 7 years ago by Samuel Jackson

Played around with it. Seems to work fine and the output now matches.

comment:31 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10042

Note: See TracTickets for help on using tickets.