Ticket #9249 (closed: fixed)

Opened 7 years ago

Last modified 5 years ago

Load ILL Reflectometry

Reported by: Ricardo Leal Owned by: Ricardo Leal
Priority: major Milestone: Release 3.2
Component: Framework Keywords: Loader ILL Reflectometry
Cc: raoul@… Blocked By: #9523
Blocking: Tester: Samuel Jackson

Description

Loader for the ILL Reflectometry instruments. To start, the loader will load Nexus data only for D17 instrument.

Change History

comment:1 Changed 7 years ago by Ricardo Ferraz Leal

Re #9249 Added auto generated files for Loader

Changeset: dc27820fd51af4680cb4015e1cafc3f2b31c2eb4

comment:2 Changed 7 years ago by Ricardo Ferraz Leal

Re #9249 Added auto generated files for Loader

Changeset: e0a3eacd27cc3dd072c454fc2c717bc426b25e9f

comment:3 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 3.3 to Release 3.2

I suspect this is meant for Release 3.2 (the current developemnt release)

comment:4 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

comment:5 Changed 7 years ago by Yannick Raoul

  • Status changed from assigned to inprogress

Re #9249 Loader for ILL/D17

Changeset: a1b28666ff67d955063622dd1de129a80903d08a

comment:6 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 Unit is set to empty

Changeset: b7b0f0e15f5f5d8346029a233058eb8ef9809bc9

comment:7 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 Param file for D17.

Changeset: 4aba21430c2c282fbfec1b18b02d3e3474fd0cce

comment:8 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 new IDF and params

Changeset: 87a93c484b639089e380f870f824cfd354b2c970

comment:9 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 Added move and get component by name

Changeset: 5ad4375c8db97c528a3e46fa21ce76e23b0cadf8

comment:10 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 updated the set nexus properties to avoid conflicts

Changeset: 0f926f8c61b22d4309b588f8750e8c911438ff64

comment:11 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 Added mapping prop names - nexus entries

Changeset: 8314a2bebc69f3afcb7175df2853e41ffe89221f

comment:12 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 Fix conflict when merg master

Changeset: f332231c90ce0d4433a864c472736dc958ac3dcd

comment:13 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 Corrected IDF. Added TODO list.

Changeset: 2a36af712ccc94c4efcc537cf79ecaa8a52aa1b4

comment:14 Changed 6 years ago by Yannick Raoul

Re #9249 Center and rotate detector according to data file

Changeset: db20f7caca23a75ec774a4d56fb9e1d9a6118896

comment:15 Changed 6 years ago by Yannick Raoul

Re #9249 Resolve conflict in develop.

Changeset: 1774231567b61a72628e6123d1a897e649650ce1

comment:16 Changed 6 years ago by Yannick Raoul

Re #9249 Resolve conflict in develop. Bad merge. Fix Build.

Changeset: 79fa9570410ba746dd298f6ee2255496a79ede53

comment:17 Changed 6 years ago by Jay Rainey

  • Blocked By 9523 added

comment:18 Changed 6 years ago by Yannick Raoul

Re #9249 Binning in tof for D17 data file

Changeset: c9edfaacb175b83a92f35ff747fe661d0d9c13e2

comment:19 Changed 6 years ago by Yannick Raoul

Re #9249 update doc format

Changeset: 9294db995c98a47399285188a40bd8ea519e13ae

comment:20 Changed 6 years ago by Yannick Raoul

Re #9249 add TOF formula on x axis

Changeset: 2756e5203b639a7d7b58a25e6a8aedc1d6c50012

comment:21 Changed 6 years ago by Yannick Raoul

Re #9249 Fix merge with master.

Changeset: db01399aefa408bc3f76f390c5e313635276d12d

comment:22 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 Added auto generated files for Loader

Changeset: dc27820fd51af4680cb4015e1cafc3f2b31c2eb4

comment:23 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 Added auto generated files for Loader

Changeset: e0a3eacd27cc3dd072c454fc2c717bc426b25e9f

comment:24 Changed 6 years ago by Yannick Raoul

Re #9249 Loader for ILL/D17

Changeset: a1b28666ff67d955063622dd1de129a80903d08a

comment:25 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 Unit is set to empty

Changeset: b7b0f0e15f5f5d8346029a233058eb8ef9809bc9

comment:26 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 Param file for D17.

Changeset: 4aba21430c2c282fbfec1b18b02d3e3474fd0cce

comment:27 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 new IDF and params

Changeset: 87a93c484b639089e380f870f824cfd354b2c970

comment:28 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 Added move and get component by name

Changeset: 5ad4375c8db97c528a3e46fa21ce76e23b0cadf8

comment:29 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 updated the set nexus properties to avoid conflicts

Changeset: 0f926f8c61b22d4309b588f8750e8c911438ff64

comment:30 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 Added mapping prop names - nexus entries

Changeset: 8314a2bebc69f3afcb7175df2853e41ffe89221f

comment:31 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 Fix conflict when merg master

Changeset: f332231c90ce0d4433a864c472736dc958ac3dcd

comment:32 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 Corrected IDF. Added TODO list.

Changeset: 2a36af712ccc94c4efcc537cf79ecaa8a52aa1b4

comment:33 Changed 6 years ago by Yannick Raoul

Re #9249 Center and rotate detector according to data file

Changeset: db20f7caca23a75ec774a4d56fb9e1d9a6118896

comment:34 Changed 6 years ago by Yannick Raoul

Re #9249 Binning in tof for D17 data file

Changeset: c9edfaacb175b83a92f35ff747fe661d0d9c13e2

comment:35 Changed 6 years ago by Yannick Raoul

Re #9249 update doc format

Changeset: 9294db995c98a47399285188a40bd8ea519e13ae

comment:36 Changed 6 years ago by Yannick Raoul

Re #9249 add TOF formula on x axis

Changeset: 2756e5203b639a7d7b58a25e6a8aedc1d6c50012

comment:37 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 Fix merge with master.

Changeset: 8efd370cfdd95ccde09a4dcb666d134ee2df0c55

comment:38 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 Fix merge into develop.

Changeset: c048233e1751279955689783ee268f01c3c67ab4

comment:39 Changed 6 years ago by Yannick Raoul

Re #9249 Added last versions of LoadHelper to avoid conflicts

Changeset: 564641153e397b70daae7bb3928d72971ca78562

comment:40 Changed 6 years ago by Yannick Raoul

Re #9249 Removed extra params from new func versions.

Changeset: 5246748375c28b1d8fc64e7b52e8eabecd8c7cfc

comment:41 Changed 6 years ago by Yannick Raoul

Re #9249 Fix merge with master

Changeset: 65e624911758188b4d369f99646f233ab0fb87ac

comment:42 Changed 6 years ago by Yannick Raoul

Re #9249 Fix merge with develop

Changeset: def611830d69d2c21bb2f91f7045b87659b6a436

comment:43 Changed 6 years ago by Ricardo Leal

To test load the file: 

ILLD17_111686.nxs

The color fill plot should sho TOF between 0 and a max value close to 6e4. You might convert units to Wavelenght to make sure everything works.

comment:44 Changed 6 years ago by Ricardo Leal

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:45 Changed 6 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:46 Changed 6 years ago by Samuel Jackson

Seems to work fine. However, I spotted that there are some random bits of commented out code scattered throughout LoadILL and LoadILLReflectometry such as:

  • 391 - LoadILL
  • 321 - LoadILL
  • 291 - LoadILLReflectometry

Doesn't seem worth reopening this close to release, and looking at the commits I don't think they were added during this ticket anyway. I created #9713 so it can be dealt with in the maintenance period.

comment:47 Changed 6 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9249_Load_ILL_Reflectometry'

Full changeset: ​0bee5be62bcfc30f71cb6108a688d0d137721e3a

comment:48 Changed 6 years ago by Ricardo Ferraz Leal

Re #9249 Fix merge into develop.

Changeset: c048233e1751279955689783ee268f01c3c67ab4

comment:49 Changed 6 years ago by Yannick Raoul

Re #9249 Fix merge with develop

Changeset: def611830d69d2c21bb2f91f7045b87659b6a436

comment:50 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10092

Note: See TracTickets for help on using tickets.