Ticket #9259 (closed: fixed)
Add Muon MUT instrument
| Reported by: | Anders Markvardsen | Owned by: | Anders Markvardsen |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.2 |
| Component: | Muon | Keywords: | |
| Cc: | stephen.cottrell@… | Blocked By: | |
| Blocking: | Tester: | Arturs Bekasovs |
Description
Add Steve's IDF, grouping file and facility.xml for MUT
Attachments
Change History
comment:2 Changed 7 years ago by Anders Markvardsen
- Status changed from assigned to verify
- Resolution set to fixed
To test load attached file using
- Load button and view instrument
- Using MuonAnalysis interface
comment:3 Changed 7 years ago by Anders Markvardsen
- Status changed from verify to reopened
- Resolution fixed deleted
comment:4 Changed 7 years ago by Anders Markvardsen
- Status changed from reopened to inprogress
Add MUT IDF, facility update etc. re #9259
Changeset: 0c785587a07595291f8ce0c1810cf1329bf1a225
comment:5 Changed 7 years ago by Anders Markvardsen
- Status changed from inprogress to verify
- Resolution set to fixed
Long live the git finish command which identitied that I had forgot to actually upload the idf etc....
comment:7 Changed 7 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:8 Changed 7 years ago by Karl Palmen
- Status changed from verifying to reopened
- Resolution fixed deleted
Code review shows comments
<!-- BRIEF DESCRIPTION OF EMU INSTRUMENT:
Data provided by Stephen Cottrell for the EMU instrument
for lines 21 to 23 for the MUT instrument definition file. They do not seem to be correct. I reopen ticket for this to be corrected.
comment:9 Changed 7 years ago by Anders Markvardsen
- Status changed from reopened to inprogress
Remove spaces and parenthesis. re #9259
In response to Russell spotting that this no good on some build platforms
Changeset: e7c7acb0ef0a6715089798dc2b134998fcd28b11
comment:10 Changed 7 years ago by Anders Markvardsen
Note a commit to include a schema has also been made to this branch but not appear here since commit to non-existing ticket number #9529. Tx to russell for spotting this
comment:11 Changed 7 years ago by Anders Markvardsen
Updated description section of IDF. re #9259
According to Karl's comment
Changeset: 7caa75f552b2952e320800582ff620055fd7ed17
comment:12 Changed 7 years ago by Russell Taylor
Re #9259. Comment out (for now) line that the schema highlights as invalid.
Changeset: fc5f833104e2df8b74d57a6734295f49dc49e6c9
comment:13 Changed 7 years ago by Anders Markvardsen
Cut out entirely line in default section. re #9259
Identified by russell to not satisfy schema and which serves no purpose
Changeset: 54a0e27396ca0815dd88fe37348d0f13dd773e09
comment:14 Changed 7 years ago by Anders Markvardsen
This instrument has been decommision. re #9259
Hence no live connection
Changeset: 7b64c6a10778154d0d285a412e59e459236b0305
comment:15 Changed 6 years ago by Anders Markvardsen
- Status changed from inprogress to verify
- Resolution set to fixed
master clean build and test looks happy. To test see comment 2
comment:16 Changed 6 years ago by Arturs Bekasovs
- Status changed from verify to verifying
- Tester changed from Karl Palmen to Arturs Bekasovs
comment:17 Changed 6 years ago by Arturs Bekasovs
No visible problems with code changes.
Was able to load the attached MUT data file. Was able to see the instrument in the Instrument View. Detector plate connections look funny though (they intersect one another), but the IDF could be improved if it doesn't satisfy data analysis needs.
I was able to do the basic analysis of the data file using the Muon Analysis interface.
comment:18 Changed 6 years ago by Arturs Bekasovs
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9259_muon_mut'
Full changeset: fa6f23987327881fea73f00eaa02ffb853ca5d28
comment:19 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10102
