Ticket #9325 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

SaveHKL issues

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description (last modified by Vickie Lynch) (diff)

SaveHKL with append=true does not save a file if it does not exist. Having it create the file would be more convenient for loops in scripts. Also SaveHKL with the append does not organize the file in the same way as anvred (according to bank for all runs together) it does it run by run this causes an issue with the histograms from the anv2gsas conversion. Also need MinIntensity parameter added and inner sort by hkl.

Change History

comment:1 Changed 6 years ago by Vickie Lynch

Refs #9325 works without scaling or corrections

Changeset: 589fa3f3ba782080029fd25a716c2c32b96951f0

comment:2 Changed 6 years ago by Vickie Lynch

Refs #9325 append works with corrections

Changeset: a1548935010f03f560e676f64453f50599270912

comment:3 Changed 6 years ago by Vickie Lynch

  • Status changed from new to assigned

comment:4 Changed 6 years ago by Vickie Lynch

  • Status changed from assigned to verify
  • Resolution set to fixed

To test: 

LoadIsawPeaks(Filename='/home/vel/mantid/Test/AutoTestData/Peaks5637.integrate',OutputWorkspace='5637')
SaveHKL(InputWorkspace='5637',ScalePeaks=0.1,LinearScatteringCoef=0.357,LinearAbsorptionCoef=0.011,Radius=0.1,Filename=r'/home/vel/5637.hkl',SortBy="Bank",MinIntensity=100)
LoadIsawPeaks(Filename='/home/vel/mantid/Test/AutoTestData/Peaks5643.integrate',OutputWorkspace='5643')
SaveHKL(InputWorkspace='5643',ScalePeaks=0.1,LinearScatteringCoef=0.357,LinearAbsorptionCoef=0.011,Radius=0.1,Filename=r'/home/vel/5637.hkl',SortBy="Bank",MinIntensity=100,AppendFile=1)
LoadHKL(Filename='/home/vel/5637.hkl',OutputWorkspace='5637_append')

comment:5 Changed 6 years ago by Vickie Lynch

  • Description modified (diff)

comment:6 Changed 6 years ago by Vickie Lynch

  • Milestone changed from Backlog to Release 3.2

comment:7 Changed 6 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:8 Changed 6 years ago by Wenduo Zhou

The new features work for the purpose.

comment:9 Changed 6 years ago by Wenduo Zhou

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9325_SaveHKL_append'

Full changeset: ​eecd199f64bb96be25be0c3be142626438b26374

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10168

Note: See TracTickets for help on using tickets.