Ticket #934 (closed: fixed)

Opened 11 years ago

Last modified 5 years ago

Wiener filter smoothing

Reported by: Roman Tolchenov Owned by: Roman Tolchenov
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Martyn Gigg

Description

Use the fortran code (attached) to add Wiener filter to FFTSmooth algorithm.

Attachments

smoo.f​ (17.1 KB) - added by Roman Tolchenov 11 years ago.

Change History

Changed 11 years ago by Roman Tolchenov

comment:1 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 26 to Iteration 27

Bulk move of tickets to iteration 27, if your ticket is essential for Iteration 26 then move it back.

comment:2 Changed 10 years ago by Nick Draper

  • Milestone changed from Iteration 27 to Iteration 28

Bulk move of tickets at the end of iteration 27

comment:3 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 28 to Iteration 29

Bulk move of tickets at the end of iteration 28

comment:4 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 29 to Iteration 30

"New" tickets moved at the code freeze of iteration 29

comment:5 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 30 to Iteration 31

Bulk move of tickets to iteration 31 at the iteration 30 code freeze

comment:6 Changed 9 years ago by Nick Draper

  • Milestone changed from Iteration 32 to Iteration 33

Moved to iteration 33 at iteration 32 code freeze

comment:7 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.1 to Release 2.2

Moved at end of release 2.1

comment:8 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.2 to Release 2.3

Moved at the end of release 2.2

comment:9 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.3 to Release 2.4

Moved to milestone 2.4

comment:10 Changed 8 years ago by Nick Draper

  • Milestone changed from Release 2.4 to Release 2.5

Moved at the code freeze for release 2.4

comment:11 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.5 to Release 2.6

Moved to r2.6 at the end of r2.5

comment:12 Changed 7 years ago by Nick Draper

  • Milestone changed from Release 2.6 to Backlog

Moved to backlog at the code freeze for R2.6

comment:13 Changed 7 years ago by Nick Draper

  • Status changed from new to assigned

Bulk move to assigned at the introduction of the triage step

comment:14 Changed 6 years ago by Roman Tolchenov

  • Component set to Framework
  • Milestone changed from Backlog to Release 3.3

comment:15 Changed 6 years ago by Roman Tolchenov

  • Status changed from assigned to inprogress

Re #934. Added WienerSmooth algorithm.

Changeset: ea0eded7bbc14cc08c8771693c71493af5d6d7bf

comment:16 Changed 6 years ago by Roman Tolchenov

Re #934. Added a unit test

Changeset: bfb5bb1c31b8e410467f20b646f8ae0b84b1f87d

comment:17 Changed 6 years ago by Martyn Gigg

There is a gcc compiler warning in WienerSmooth.cpp: ​http://builds.mantidproject.org/job/develop_clean/label=ubuntu-12.04-build/291/warnings19Result/

comment:18 Changed 6 years ago by Roman Tolchenov

Re #934. Fix the docs build

Changeset: 29bd50df0d414f38c4a8040d88eaedb3a1f4908b

comment:19 Changed 6 years ago by Roman Tolchenov

Re #934. More tests. Special cases.

Changeset: b84f7308948ab95981708b3605861ee6207ed62a

comment:20 Changed 6 years ago by Roman Tolchenov

Re #934. WienerSmooth doesn't change spectrum size.

Changeset: 0643e4fc2479a1a7287d19f38bde01944b745bc7

comment:21 Changed 6 years ago by Roman Tolchenov

Re #934. The rst documentation. Changes to logging.

Changeset: 74fd89f457ee8bbdb776895d8fe2e76da3f0dfdb

comment:22 Changed 6 years ago by Roman Tolchenov

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:23 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester set to Martyn Gigg

comment:24 Changed 6 years ago by Martyn Gigg

The algorithm appears to do as was required by the fortran code.

A few improvements have been suggested in #10256. Passed here for it to be tested by other users on a nightly build.

comment:25 Changed 6 years ago by Martyn Gigg

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/934_wiener_filter'

Full changeset: ​896de7aba990a7f5967cce0ae26faf67b200818c

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​1782

Note: See TracTickets for help on using tickets.