Ticket #9345 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Convert IndirectJumpFit to python workflow algoritm

Reported by: Samuel Jackson Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: Indirect Inelastic Keywords:
Cc: Blocked By:
Blocking: #10277 Tester: Martyn Gigg

Description

This is basically a workflow algorithm anyway. We could just:

  • Convert IndirectJumpFit to a workflow algorithm
  • Move it into the python workflow algorithms directory
  • Update the interface to create the algorithm with AlgorithmRunner.
    • Be sure to set rethrows so the interface catches errors.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Samuel Jackson

It may be work thinking about this a little more. I think there might be a way of combining the fitting code for MSDFit, FuryFit, ConvFit and JumpFit into a generic fitting routine. Having said that, JumpFit is more dissimilar to the three in IDA and may worth just being on its own.

comment:3 Changed 6 years ago by Nick Draper

  • Owner changed from Samuel Jackson to Dan Nixon

comment:4 Changed 6 years ago by Dan Nixon

  • Milestone changed from Backlog to Release 3.3

comment:5 Changed 6 years ago by Dan Nixon

  • Status changed from assigned to inprogress

Move jump fit from Python script to algoriithm

Refs #9345

Changeset: 62602d947fa764f71a6b2d661fcc12520764b937

comment:6 Changed 6 years ago by Dan Nixon

Added use of algorithm to UI

Refs #9345

Changeset: 097bb3d6a941c1ab6dd4d27dab9abeb26335249d

comment:7 Changed 6 years ago by Dan Nixon

Minor refactoring, added docs

Refs #9345

Changeset: b0c427a313dc44e1a1439cfeb219509c4611a510

comment:8 Changed 6 years ago by Dan Nixon

Merge branch 'feature/9345_indirect_jumpfit_python_algorithm' into develop

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectJumpFit.py

Refs #9345

Changeset: 8b2a8d45a0712967aa5f0a865491094cb046b19f

comment:9 Changed 6 years ago by Dan Nixon

Fix failing unit test

Refs #9345

Changeset: d09659abef6225e9cd0d1ee90d4dc8cc0351e305

comment:10 Changed 6 years ago by Martyn Gigg

There are a bunch of new Pylint warnings: http://builds.mantidproject.org/view/Static%20Analysis/job/pylint_develop/violations/file/JumpFit.py/

Can we try and avoid things like the 'from mantid.simpleapi import *' in PyExec, along with the from IndirectCommon import * and only import what we use. It would help clean up some of these errors.

comment:11 Changed 6 years ago by Martyn Gigg

I think this has also broken some system tests: http://builds.mantidproject.org/job/develop_systemtests_rhel6/482/

comment:12 Changed 6 years ago by Dan Nixon

Change JumpFit system tests for new Python algo

Refs #9345

Changeset: 309d3c4d74ffa67203f9322cce98d44fd6a9ca3a

comment:13 Changed 6 years ago by Dan Nixon

Improved Python code style

Removed unused imports, shortened functions

Refs #9345

Changeset: dbaf58102aa22e59fbbf36ef5d403446abf1708a

comment:14 Changed 6 years ago by Dan Nixon

Reduced line lengths, fix a few pylint warnings

Refs #9345

Changeset: cfb16648129a8bbdd77f95564b955a37632aa8c3

comment:15 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Test:

  • Ensure system test is passing (ISISIndirectBayesTest)
  • Ensure Indirect Bayes > Jump Fit still works in all fitting modes

Note that there are changes to systemtests with this ticket.

Last edited 6 years ago by Dan Nixon (previous) (diff)

comment:16 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:17 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to reopened
  • Resolution fixed deleted

Merge conflict when merging to master.

comment:18 Changed 6 years ago by Dan Nixon

  • Status changed from reopened to inprogress

Merge branch 'master' into feature/9345_indirect_jumpfit_python_algorithm

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectJumpFit.py

Refs #9345

Changeset: 232de83bcad8f995c5f82a665591c412e31c1af3

comment:19 Changed 6 years ago by Dan Nixon

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:20 Changed 6 years ago by Dan Nixon

  • Blocking 10277 added

comment:21 Changed 6 years ago by Martyn Gigg

  • Status changed from verify to verifying
  • Tester changed from Roman Tolchenov to Martyn Gigg

comment:22 Changed 6 years ago by Dan Nixon

  • Status changed from verifying to closed

Merge branch 'master' into feature/9345_indirect_jumpfit_python_algorithm

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectJumpFit.py

Refs #9345

Full changeset: 232de83bcad8f995c5f82a665591c412e31c1af3

comment:23 Changed 6 years ago by Martyn Gigg

Merge remote-tracking branch 'origin/feature/9345_indirect_jumpfit_python_algorithm'

Full changeset: 2102133fc88801ac54ca86a8619f0b1e9d93dbaf

comment:24 Changed 6 years ago by Martyn Gigg

Merge branch 'feature/9345_indirect_jumpfit_python_algorithm'

Full changeset: 277988074398d622dbe4b494139ed729203b3100

comment:25 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10188

Note: See TracTickets for help on using tickets.