Ticket #9387 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

ISIS iliad does not work with VB run provided as workspace.

Reported by: Alex Buts Owned by: Alex Buts
Priority: major Milestone: Release 3.2
Component: Direct Inelastic Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

Try to run Merlin reduction script:

"""
sample Direct inelastic reduction for MERLIN performed in absolute units
"""
from qtiGenie import *
#from PySlice2 import *

# Calculates 

inst='MER'
iliad_setup(inst)


# where to save resutls (usually specified in Mantid, data search directories)
save_dir = config.getString('defaultsave.directory')
if len(save_dir) ==0 :
    config['defaultsave.directory']=os.getcwd()
    save_dir = config.getString('defaultsave.directory')
    
print "Data will be saved into: ",save_dir
# map mask and cal file, again the values from Mantid, data search directories can be modified here
config.appendDataSearchDir('/home/merlin/mprogs/InstrumentFiles/merlin') 
# data (raw or nxs) run files -- values from data search directories can be modified here
config.appendDataSearchDir('/isisdatar55/NDXMERLIN/Instrument/data/cycle_12_5') 
#load vanadium file    
whitebeamfile="14338"
LoadRaw(Filename=whitebeamfile,OutputWorkspace="wb_wksp",LoadLogFiles="0")
MonoVanWB="wb_wksp"

# Mandatory positional parameters 
ei=15
rebin_params=[-20, 0.1, 14]
MonoVanRun=[14746]
monows=LoadRaw(Filename=str(MonoVanRun[0]),OutputWorkspace="monovan_wksp",LoadLogFiles="0",LoadMonitors='Include')
#RenameWorkspace(InputWorkspace="monovan_wksp_Monitors",OutputWorkspace="monovan_wksp_monitors")


#params['monovan_mapfile']='rings_125.map' 
#   Other positional  parameters
mapfile='rings_125' # ring map file is used for powder.  if absend idf file value is used instead
# key-coded parameters
params={}
params['vanadium-mass']=32.62   #   7.85
params['monovan_integr_range']=[-15,13.5]
params['norm_method']='current'
params['det_cal_file']='det_corr_125.dat'  #det_cal_file must be specified if the reduction sends out put to a workpsace
params['sample_mass']=3.56   #CePdSi3
params['sample_rmm']=330.750  #CePdSi3
params['monovan_mapfile']='rings_125.map' # good 
#params['hardmaskPlus']='mask6.msk'
#params['hardmaskOnly']='mask6.msk'
#following two lines need to be uncomented tohad  maks work ok with "False"
#params['use_hard_mask_only']=False
#params['hard_mask_file']='mask6v2.msk'
#params['hardmaskOnly']='' # no mask
params['hardmaskOnly']='/home/merlin/mprogs/InstrumentFiles/merlin/Bjorn_mask.msk' 
#CePdSi3 15meV runs
runs=[14695, 14696, 14697,14698,14799,14702]
############## normal reduction####################

#save .nxspe file
for runfile in runs:
	save_file=inst+str(runfile)+'_abs.spe'
	LoadRaw(Filename=str(runfile),OutputWorkspace="run_wksp",LoadLogFiles="0")

  #  w1=iliad("wb_wksp","run_wksp",ei,rebin_params,mapfile,**params)
    
	w1=iliad("wb_wksp","run_wksp",ei,rebin_params,mapfile,monows,**params)

	SaveSPE('w1',save_file)
print "All done"


It fails on trying to calculate WB integrals. Should be fixed.

Change History

comment:1 Changed 6 years ago by Alex Buts

refs #9387 This should fix it

Changeset: 6b529f6af59428fb9840be2d2a6df7c99d9f8319

comment:2 Changed 6 years ago by Alex Buts

refs #9387 Spelling errors

Changeset: 92b1bcccc507357f8551442ba6c79e5af476e775

comment:3 Changed 6 years ago by Alex Buts

  • Status changed from new to assigned

To run this script, tester should either checkout qtiGenie from https://github.com/mantidproject/scripts/tree/master/inelastic/direct_geometry/qtiGenie and add this folder to Mantid python scripts search path, or modify the script according to changes ISISDirectInelastic system tests (replace iliad and iliad_setup with correspondent dgreduce references.

But the changes are actually trivial, and consist of changing Common functions to accept not only run number but also the pointer to workspace and workspace name (see first commit)

As I've already run the script above, deployed the changes to common functions on Merlin, and system tests are passing, the tester can safely accept the changes by code review.

comment:4 Changed 6 years ago by Alex Buts

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:5 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:6 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9387_IliadWithWB_WS'

Full changeset: 4dfef9495037e4f71b82176c75217589fbdcc75a

comment:7 Changed 6 years ago by Anders Markvardsen

with some changes to path found attached scrip ran

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10230

Note: See TracTickets for help on using tickets.