Ticket #9403 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Save Workspace Issue in ReflGui

Reported by: Owen Arnold Owned by: Keith Brown
Priority: blocker Milestone: Release 3.2
Component: Reflectometry Keywords:
Cc: Blocked By:
Blocking: Tester: Alex Buts

Description

Message from max regarding not being able to save workspaces from the ReflGUI.

Could not open save workspace dialog
[Errno 2] No such file or directory: '\\\\isis\\inst$\\NDXINTER\\Instrument\\logs\\journal\\journal_main.xml'

I think it's caused by lines 245-269, where I tried to get to the user path in the archive, which of course does not work off-line. Could you perhaps fix that.

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Keith Brown

  • Status changed from assigned to inprogress

Refs #9403 Save Workspaces dialog can now be opened offline

The Save workspaces dialog can now be opened under all the following circumstances, whereas before it would raise an exception and not show:

  • The workstation is not connected to a network or loses it's connection to a network
  • The archives aren't available or aren't mounted
  • A config.xml file isn't in place or doesn't contain a mount point location

Changeset: 5a9954b526137f7c4c6ddad16597644eae926471

comment:3 Changed 6 years ago by Keith Brown

  • Status changed from inprogress to verify
  • Resolution set to fixed

To tester

You must have a connection to the ISIS archives to test this.

Open the ISIS reflectometry GUI and process some runs as seen here to generate some workspaces. (Note: ignore the fact that the plots don't appear, this no longer happens automatically - the docs will be updated soon)

Go File->Save Workspaces... and verify that the dialog loads.

Close the Save Workspaces dialog.

Now manually disconnect your computer from the network. You may choose to just unmount the archives if it's possible on your OS, but the reported specifically mentioned offline usage so total disconnection is preferred

Go File->Save Workspaces... and verify that the dialog loads. Before, This would have raised an exception and the dialog wouldn't have been shown (you can verify this on the current official release).

comment:4 Changed 6 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:5 Changed 6 years ago by Alex Buts

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9403_Refl_Offline_Save_Workspaces'

Full changeset: eed068199536192a384b4211be9f3a7feb8cbbf6

comment:6 Changed 6 years ago by Alex Buts

The ticket does what it says, but is in some way useless.

Failure was occurring offline only, and despite this issue was fixed, the script does not work offline properly anyway. E.g. you can not save workspaces if u:
disk is not present.

I am not familiar with this workflow and usage scenarios, so the developer should think if other thicket are needed to provide normal offline operations.

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10246

Note: See TracTickets for help on using tickets.