Ticket #9404 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Create RemoveWorkspaceHistory algorithm

Reported by: Samuel Jackson Owned by: Samuel Jackson
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By: #8913
Blocking: Tester: Karl Palmen

Description

With the updates to algorithm histories pending, it would be useful to have an algorithm that can remove the history from a workspace, for example, in the cases where it becomes to bloated.

Attachments

test_hist.py (391 bytes) - added by Samuel Jackson 6 years ago.
Testing script

Change History

comment:1 Changed 6 years ago by Samuel Jackson

  • Blocked By 8913 added

comment:2 Changed 6 years ago by Owen Arnold

  • Status changed from new to infoneeded

I could see how this could be useful, but I have two concerns. Developers/programming users use it as an optimisation when writing their own algorithms. If this was being used as a child algorithm then it could badly affect any algorithm chains built using the algorithm that removed the history.

I'm not dead against this, but is this really necessary? Wouldn't it be better to tackle the bloat issue?

comment:3 Changed 6 years ago by Samuel Jackson

I agree with your point that this breaks the chain of algorithms in a workflow history. I also agree that bloat should be tackled elsewhere, but it's inevitable that if you run enough algorithms on a workspace, it's history will become large. I think that even with good performance there should be an option to remove history if you really want to.

Perhaps a better approach would be to supply an option somewhere (logically the history GUI?) which can remove a workspaces' history rather than an algorithm. This would avoid the broken history issue. In which case this should be closed as invalid and the requirement added to ticket #9369.

comment:4 Changed 6 years ago by Nick Draper

  • Status changed from infoneeded to new

comment:5 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

I prefer all actions in Mantid to be available through a common interface - algorithms. We could put the button on the GUI as well, but if slow history usage affects a users script they need to be able to solve it from Python.

comment:6 Changed 6 years ago by Samuel Jackson

  • Status changed from assigned to inprogress

Refs #9404 Add algorithm to remove algorithm history from a workspace.

Changeset: 609e9e200eef8ae24bd5c2bd994ceb151c1297e6

comment:7 Changed 6 years ago by Samuel Jackson

Refs #9404 Swap to using new wiki summary method.

Changeset: a975e38fd3fc9304bc7ce34f809213ab20e008a3

comment:8 Changed 6 years ago by Samuel Jackson

Refs #9404 Missed summary method in dummy unit test algorithms.

Changeset: b0be2d441f04d608b9ed31591704584537528390

comment:9 Changed 6 years ago by Samuel Jackson

Refs #9404 Add missing return statement.

Changeset: d4982cbf02c0b5e4f1dbc747c9fe89642cc45f30

Changed 6 years ago by Samuel Jackson

Testing script

comment:10 Changed 6 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Test

Run the script. It will generate some nested history and print out what it contains. Then run the algorithm on the workspace, open the history gui and check that the only entry is RemoveWorkspaceHistory.

comment:11 Changed 6 years ago by Karl Palmen

  • Status changed from verify to verifying
  • Tester set to Karl Palmen

comment:12 Changed 6 years ago by Karl Palmen

  • Status changed from verifying to reopened
  • Resolution fixed deleted

This ticket needs a checkbuild before it can be tested. Please checkbuild it and return it to verify if successful. I think this is necessary, because the develop branch was set back to master since your last checkbuild.

comment:13 Changed 6 years ago by Samuel Jackson

Should be back on develop now.

comment:14 Changed 6 years ago by Samuel Jackson

  • Status changed from reopened to verify
  • Resolution set to fixed

comment:15 Changed 6 years ago by Karl Palmen

  • Status changed from verify to verifying

comment:16 Changed 6 years ago by Karl Palmen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9404_remove_history_algorithm'

Full changeset: 1fe46e153f3a17e2427599424836df183aa76845

comment:17 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10247

Note: See TracTickets for help on using tickets.