Ticket #9407 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Remove the warning from MultiDomainCreator

Reported by: Roman Tolchenov Owned by: Peter Peterson
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: zhouw@… Blocked By:
Blocking: Tester: Wenduo Zhou

Description

The warning is supposed to draw the developer's attention to the fact that if a function is applied to multiple domains only one of them is used to set up the workspace (call setMatrixWorkspace method).

This type of fitting is used in FindPeaks and results in too many unnecessary warnings issued.

Change History

comment:1 Changed 6 years ago by Owen Arnold

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Peter Peterson

  • Cc zhouw@… added

comment:3 Changed 6 years ago by Peter Peterson

  • Owner changed from Roman Tolchenov to Peter Peterson
  • Status changed from assigned to inprogress

comment:4 Changed 6 years ago by Pete Peterson

Re #9407. Comment out logging that bogs down FindPeaks.

Changeset: f8a23f1b976e8d5668fc59c42470d423b5a1abc6

comment:5 Changed 6 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is on ​bugfix/9407_multi_domain_warnings

To test: just look at the commented out code.

comment:6 Changed 6 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:7 Changed 6 years ago by Wenduo Zhou

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9407_multi_domain_warnings'

Full changeset: ​ad8571c7f318caf57278a10148d275abc9dc65a7

comment:8 Changed 6 years ago by Wenduo Zhou

Great! The execution time of GetDetOffsetsMultiPeaks on NOMAD data is reduced by 200%.

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10250

Note: See TracTickets for help on using tickets.