Ticket #9432 (closed: fixed)
Integrate peak search and fit algorithms specific to POLDI
| Reported by: | Michael Wedel | Owned by: | Michael Wedel |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.2 |
| Component: | Diffraction | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #9445 | Tester: | Roman Tolchenov |
Description
Peak search and fit routines for the correlation spectra of POLDI have to be added, corresponding closely to the existing data analysis software.
Change History
comment:2 Changed 6 years ago by Michael Wedel
Refs #9432. Cleaned up PoldiPeakCollection and PoldiFitPeaks1D
Some functionality has been transfered from PoldiPeakCollection to PoldiFitPeaks1D, as it was too closely linked to PoldiFitPeaks1D. For PoldiFitPeaks1D there are some unit tests now, but a system test will be added to make sure everything works properly.
Changeset: 2e661ce9961809fe7220332f201abee8c07e9072
comment:3 Changed 6 years ago by Michael Wedel
Refs #9432. Added unit test for PoldiFitPeaks1D properties
Changeset: a8e8f8dcb8d64050cd91930a8b82e4a529092efc
comment:4 Changed 6 years ago by Michael Wedel
Refs #9432. Changed constructor of MillerIndices
Changeset: 55aab4d72b25a039200dcb0bc46de2f24c2b1293
comment:5 Changed 6 years ago by Michael Wedel
Refs #9432. Removed forgotten piece of C++11 from PoldiPeakSearch
Changeset: 969349e4f55a22c8ba999a8a9349ab2aa45034de
comment:6 Changed 6 years ago by Michael Wedel
Refs #9432. Changed loop index from size_t to int in PoldiPeakSearch
Required for building on certain platforms for parallelization support.
Changeset: 38240cc8d02262f6b272c58056a307eb90c6066c
comment:7 Changed 6 years ago by Michael Wedel
Refs #9432. Fixed warning in PoldiPeakCollectionTest, external symbols
Changeset: 4eebb26859af37e1ff6aafb64b1fd8042ad98497
comment:8 Changed 6 years ago by Michael Wedel
Refs #9432. Modified PoldiPeakSearch::findPeaks to not use std::next
Changeset: 40cd51fe6c3420ab21652b55e6a4ed31f6fb367f
comment:9 Changed 6 years ago by Michael Wedel
Refs #9432. Replaced std::list::merge with std::list::insert
Apparently, std::list::merge is not available in all versions of the standard library.
Changeset: a6b71b9c86a641f68bbac4f1de1ff7ac9ced3243
comment:12 Changed 6 years ago by Michael Wedel
- Status changed from assigned to inprogress
Refs #9432. Added system test for PoldiPeakSearch
Changeset: e8fba3b6e915b4a93c0767ae959c5981826f6a4f
comment:13 Changed 6 years ago by Michael Wedel
Refs #9432. Added system test for PoldiFitPeaks1D
Changeset: 6643f04da2b7e0d51310a453d8b5f448cc90c041
comment:14 Changed 6 years ago by Michael Wedel
- Status changed from inprogress to verify
- Resolution set to fixed
comment:15 Changed 6 years ago by Michael Wedel
Testing information: Unit tests are available for most methods and passed checkbuild. In addition there are two system tests (POLDIPeakSearchTest and POLDIFitPeaks1DTest) which compare the results of the algorithms with results obtained from the existing data analysis software.
comment:17 Changed 6 years ago by Roman Tolchenov
- Status changed from verify to verifying
- Tester set to Roman Tolchenov
comment:18 Changed 6 years ago by Roman Tolchenov
Not all functions and methods have doxygen comments. Maybe in the future it's you can add them.
comment:19 Changed 6 years ago by Roman Tolchenov
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9432_integrating_poldi_peak_search_and_fit'
Full changeset: 60d5d46f27b3ba8bd114706b5a41fa54eb144432
comment:20 Changed 6 years ago by Roman Tolchenov
Merge remote-tracking branch 'origin/feature/9432_system_tests_poldi_peak_search_and_fit'
Full changeset: 8d806a681b739b0619ea5e456e579fd2ce93c5b5
comment:21 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10275
