Ticket #9434 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Slot connection error on starting instrument window

Reported by: Russell Taylor Owned by: Martyn Gigg
Priority: major Milestone: Release 3.2
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Anders Markvardsen

Description

Following the changes in #9402, the following error message shows up when the instrument window is fired up: 

 Object::connect: No such slot MantidUI::plot1D(const QString&,const std::set<int>&)
 Object::connect:  (sender name:   'InstrumentWindow:ws')

This is because the signature to plot1D has changed.

Change History

comment:1 Changed 6 years ago by Martyn Gigg

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Martyn Gigg

  • Status changed from assigned to inprogress

Remove unused actions from InstrumentWindow.

These were old actions that used to be on a context menu but are no longer required. Refs #9434

Changeset: 165abfb4d75d63daebe7a1cc81a853c3f926071f

comment:3 Changed 6 years ago by Martyn Gigg

  • Status changed from inprogress to verify
  • Resolution set to fixed

Branch: bugfix/9434_fix_slot_connect_err_instwin

Tester: These outputs may not be seen as easily on Windows as it depends if you have the console activated or not. Load any file that will result in creating an instrument and show it in the display. The shell should be clear of warnings about a missing slot.

comment:4 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:5 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9434_fix_slot_connect_err_instwin'

Full changeset: ​0d9da94e1adc04ce388ca0d0874ed01f2ef0021d

comment:6 Changed 6 years ago by Anders Markvardsen

Tried with INTER and CHRONUS and did see any missing slots (or other) errors in console

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10277

Note: See TracTickets for help on using tickets.