Ticket #9458 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Display Mask for Histogram (Added) Data Throws Error

Reported by: Peter Parker Owned by: Peter Parker
Priority: critical Milestone: Release 3.2
Component: SANS Keywords:
Cc: anders.markvardsen@… Blocked By:
Blocking: Tester: Anders Markvardsen

Description

From Richard:

If I do display mask on a histogram (added) data file 2380-add it falls over trying to delete a workspace that does not exist. 

ValueError: Invalid value for property InputWorkspace (Workspace) "23808_sans_nxs_monitors": Workspace "23808_sans_nxs_monitors" was not found in the Analysis Data Service
at line 12462 in '<Interface>'
caused by line 1012 in 'C:/MantidInstall/scripts/SANS\ISISCommandInterface.py'
caused by line 566 in 'C:/MantidInstall/bin\mantid\simpleapi.py'
caused by line 530 in 'C:/MantidInstall/bin\mantid\simpleapi.py'

A quick code inspection reveals that -- in the case of historgram data -- we should just be able to avoid doing the CloneWorkspace at 1012.

Change History

comment:1 Changed 6 years ago by Peter Parker

  • Component changed from Framework to SANS

comment:2 Changed 6 years ago by Peter Parker

  • Status changed from new to assigned
  • Cc anders.markvardsen@… added

comment:3 Changed 6 years ago by Peter Parker

  • Status changed from assigned to inprogress

Refs #9458 - Make sure we don't trip up on added (histogram) data...

... when displaying masks.

Changeset: 928b6415dc65ef23b8804076959dc31d50ed66c4

comment:4 Changed 6 years ago by Peter Parker

Refs #9458 - Make sure we can add data with SANS2DTUBES option.

Changeset: 8b6329e8a2133ad491294962493c416a2d4db954

comment:5 Changed 6 years ago by Peter Parker

  • Status changed from inprogress to verify
  • Resolution set to fixed

@Anders - To test:

  • Open the interface and make sure SANS2DTUBES is selected.
  • Load the MASKSANS2D_141E_4m_SER_M3_8mm_FrontDet.txt User File from \\isis\inst$\NDXSANS2D\user\Masks\.
  • Go to the Add Runs tab and use it to add SANS2D runs 23792-23785 from the archive.
  • Load the added file as a sample using the interface.
  • Run "Display Mask". The mask probably won't align or make much sense, but as long as it is using the new IDF (staggered tubes), and as long as there were no errors, then it is fine.

These changes were very small and do not touch any code used by the system tests, so no need to wait until tomorrow for this one.

comment:6 Changed 6 years ago by Anders Markvardsen

  • Status changed from verify to verifying
  • Tester set to Anders Markvardsen

comment:7 Changed 6 years ago by Anders Markvardsen

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9458_fix_display_mask_for_added_data'

Full changeset: ​0a31edc4662ef484058b040f36f8cf3b6c966cb9

comment:8 Changed 6 years ago by Anders Markvardsen

Got staggered tubes in display mask and 1D reduce also run without errors

comment:9 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10301

Note: See TracTickets for help on using tickets.