Ticket #9464 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add options to PD reduction gui

Reported by: Peter Peterson Owned by: Peter Peterson
Priority: critical Milestone: Release 3.2
Component: Diffraction Keywords:
Cc: Blocked By:
Blocking: Tester: Wenduo Zhou

Description (last modified by Peter Peterson) (diff)

The variable ScaleData in SNSPowderReduction needs to be in the gui.

Change FilterBadPulses to be a float for the value of LowerCutoff (in FilterBadPulses), and change SNSPowderReduction to use it as well.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Peter Peterson

  • Priority changed from major to critical
  • Milestone changed from Backlog to Release 3.2

comment:3 Changed 6 years ago by Peter Peterson

  • Status changed from assigned to inprogress

comment:4 Changed 6 years ago by Peter Peterson

  • Description modified (diff)
  • Summary changed from Add option to scale data to PD reduction gui to Add options to PD reduction gui

comment:5 Changed 6 years ago by Pete Peterson

Re #9464. Created utility for compiling ui files for python.

Changeset: 8e5971cf796801d9055552c45cd9c9c850f2983b

comment:6 Changed 6 years ago by Pete Peterson

Re #9464. Adding script to compile diffraction ui.

Changeset: 35ef886ae98e1b90a550fb386c86c8d940e97daa

comment:7 Changed 6 years ago by Pete Peterson

Re #9464. Adding ScaleData to the gui.

Changeset: e995c4bffb4d707eb5e57560073cb9c0b5c10e1c

comment:8 Changed 6 years ago by Pete Peterson

Re #9464. Connecting ScaleData the rest of the way down.

Changeset: f8bb033885c628e7c9aac852d7568a915592686c

comment:9 Changed 6 years ago by Pete Peterson

Re #9464. Refactored code to have less repetition.

Changeset: 3f306cd091bd7fa071a56d4f09fd7670951110a4

comment:10 Changed 6 years ago by Pete Peterson

Re #9464. Changed FilterBadPulses parameter to be a float.

Changeset: be4abe9c80816ca6d8d2f84202c246b28ec58a3e

comment:11 Changed 6 years ago by Pete Peterson

Re #9464. Changed FilterBadPulses to be a float parameter.

Changeset: b7301a4503b88f26ed1bb59f2bffbe13e108ef89

comment:12 Changed 6 years ago by Pete Peterson

Re #9464. Following signature change of SNSPowderReduction.

Changeset: f4a9df8d1989ee75b66f1438fc16f5f4837fec53

comment:13 Changed 6 years ago by Pete Peterson

Merge branch 'feature/9464_scale_pd' into develop

Re #9464.

Conflicts:

Code/Mantid/docs/source/algorithms/LoadDetectorInfo-v1.rst Code/Mantid/docs/source/algorithms/SANSWideAngleCorrection-v1.rst

Changeset: 4764ef782fccefcbe4d65c0d27b80d4967da374c

comment:14 Changed 6 years ago by Peter Peterson

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is on mantid:​feature/9464_scale_pd and systemtests:​feature/9464_scale_pd. Don't forget to merge both.

To test: Try out both

  • (algorithm) SNSPowderReduction
  • (interface) Interfaces->Diffraction->Powder Diffraction Reduction

comment:15 Changed 6 years ago by Karl Palmen

The wiki category Algorithms does not list the algorithms in strict alphabetical order, but with capitals before 'a'. Hence SNSPowderReduction is found betweeen the SCDCalibratePanels and SassenaFFT.

comment:16 Changed 6 years ago by Wenduo Zhou

  • Status changed from verify to verifying
  • Tester set to Wenduo Zhou

comment:17 Changed 6 years ago by Wenduo Zhou

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9464_scale_pd'

Full changeset: ​de77ae7385284f01035c80619ec422ab28218bf2

comment:18 Changed 6 years ago by Wenduo Zhou

Merge remote-tracking branch 'origin/feature/9464_scale_pd'

Full changeset: ​7ad7f124a53dc2441cce769fa86999c10ae2d1be

comment:19 Changed 6 years ago by Wenduo Zhou

The system test passes with new features. Same result can be generated from diffraction GUI.

comment:20 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10307

Note: See TracTickets for help on using tickets.