Ticket #9480 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

SaveZODS needs column major order for ZODS

Reported by: Vickie Lynch Owned by: Vickie Lynch
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Michael Reuter

Description

With 3D data, it is obvious that the row major order input from Nexus functions in Mantid is wrong.

Change History

comment:1 Changed 6 years ago by Vickie Lynch

Refs #9480 Works for 3D data

Changeset: 4cc5f364355cc5bedaa06d64cb6ed7a800fe4655

comment:2 Changed 6 years ago by Vickie Lynch

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Vickie Lynch

  • Status changed from assigned to inprogress

Refs #9480 Did not mean to change dimension name

Changeset: 0e3978284e22338d1d009b27cc8e694d978ca9b0

comment:4 Changed 6 years ago by Vickie Lynch

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test use TOPAZ file in system test 

Load(Filename=r'TOPAZ_3132_event.nxs',OutputWorkspace='TOPAZ_3132_event',LoadMonitors='1')
ConvertToMD(InputWorkspace='TOPAZ_3132_event',QDimensions='Q3D',dEAnalysisMode='Elastic',Q3DFrames='Q_sample',LorentzCorrection='1',OutputWorkspace='TOPAZ_3132_md',MinValues='-25,-25,-25',MaxValues='25,25,25',SplitInto='2',SplitThreshold='50',MaxRecursionDepth='13',MinRecursionDepth='7')
FindPeaksMD(InputWorkspace='TOPAZ_3132_md',PeakDistanceThreshold='0.37680000000000002',MaxPeaks='50',DensityThresholdFactor='100',OutputWorkspace='TOPAZ_3132_peaks')
FindUBUsingFFT(PeaksWorkspace='TOPAZ_3132_peaks',MinD='3',MaxD='15',Tolerance='0.12')
CopySample(InputWorkspace='TOPAZ_3132_peaks',OutputWorkspace='TOPAZ_3132_event',CopyName='0',CopyMaterial='0',CopyEnvironment='0',CopyShape='0')
IndexPeaks(PeaksWorkspace='TOPAZ_3132_peaks',Tolerance='0.12')
ShowPossibleCells(PeaksWorkspace='TOPAZ_3132_peaks')
SelectCellOfType(PeaksWorkspace='TOPAZ_3132_peaks',CellType='Orthorhombic',Apply='1')
CopySample(InputWorkspace='TOPAZ_3132_peaks',OutputWorkspace='TOPAZ_3132_event',CopyName='0',CopyMaterial='0',CopyEnvironment='0',CopyShape='0')
ConvertToMD(InputWorkspace='TOPAZ_3132_event',QDimensions='Q3D',dEAnalysisMode='Elastic',QConversionScales='HKL',LorentzCorrection='1',OutputWorkspace='TOPAZ_3132_HKL',MinValues='-25,-25,-25',MaxValues='25,25,25',SplitInto='2',SplitThreshold='150')
BinMD(InputWorkspace='TOPAZ_3132_HKL',AlignedDim0='[H,0,0],-5,5,201',AlignedDim1='[0,K,0],-5,5,201',AlignedDim2='[0,0,L],-5,5,201',Parallel='1',OutputWorkspace='TOPAZ_3132_HKL_binned')
SaveZODS(InputWorkspace='TOPAZ_3132_HKL_binned',FileName='TOPAZ_3132.h5')

/SNS/users/vel/zods_01/release/bin/convert i hdf5 /SNS/users/vel/TOPAZ_3132.h5 vtk TOPAZ_3132.vtk

Look at vtk file with paraview and it should look like TOPAZ_3132_HKL_binned in sliceview

comment:5 Changed 6 years ago by Michael Reuter

  • Status changed from verify to verifying
  • Tester set to Michael Reuter

comment:6 Changed 6 years ago by Michael Reuter

  • Status changed from verifying to reopened
  • Resolution fixed deleted

The data looks like it gets axis swapped and there seems to be a factor of 2pi missing.

comment:7 Changed 6 years ago by Vickie Lynch

  • Status changed from reopened to verify
  • Resolution set to fixed

I did not realize that the ZODS convert transformed the data from HKL to Q space. I removed the transformation call from my copy of convert for the testing.

comment:8 Changed 6 years ago by Michael Reuter

  • Status changed from verify to verifying

comment:9 Changed 6 years ago by Michael Reuter

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9480_SaveZODS_column_major_order'

Full changeset: ​e19a7aa08bec1db327e322483c2b09a5845c9635

comment:10 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10323

Note: See TracTickets for help on using tickets.