Ticket #9481 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Stop the Reduction if Mask File Not Found

Reported by: Peter Parker Owned by: Peter Parker
Priority: major Milestone: Release 3.2
Component: SANS Keywords:
Cc: Blocked By:
Blocking: Tester: Jay Rainey

Description (last modified by Peter Parker) (diff)

Richard has pointed out that simply printing a warning when the ISIS SANS reduction cannot find the specified mask file is not enough -- the red text is lost in a sea of other log messages.

He would like the reduction to complete stop, instead.

Change History

comment:1 Changed 6 years ago by Peter Parker

  • Description modified (diff)

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Peter Parker

  • Status changed from assigned to inprogress

Refs #9481 - Stop reduction on missing mask file.

Changeset: c4c6edd2a879ac9a8dda75ab9d9727d8288a98b2

comment:4 Changed 6 years ago by Peter Parker

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test (ISIS only):

  • The \\olympic\babylon5\Public\PGP\Test Data\9481 folder contains the files needed to test this ticket. Add it to Mantid's Managed Directory list.
  • Open up the ISIS SANS interface and select the "SANS2D" instrument.
  • Load the "MaskSANS2DReductionGUI_MissingMaskFiles.txt" User File. This contains a reference to a non-existent mask file.
  • Type "22048" in the Scattering Sample field and then click "Load Data".
  • Click "1D Reduce". The reduction should stop with an error message, making it clear that the mask file could not be found.
  • Do the same but with "MaskSANS2DReductionGUI_MaskFiles.txt" to see the reduction go through without any problems.

comment:5 Changed 6 years ago by Jay Rainey

  • Status changed from verify to verifying
  • Tester set to Jay Rainey

comment:6 Changed 6 years ago by Jay Rainey

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9481_stop_reduction_if_mask_file_not_found'

Full changeset: 9faa5b72d169abbb4a401b071add70a59e274c25

comment:7 Changed 6 years ago by Jay Rainey

An error message is now thrown and is no longer lost in the sea of log messages. Code change was sensible.

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10324

Note: See TracTickets for help on using tickets.