Ticket #9489 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add missing property widgets to the DataLoading step

Reported by: Arturs Bekasovs Owned by: Raquel Alvarez Banos
Priority: critical Milestone: Release 3.4
Component: Muon Keywords: ALC
Cc: Blocked By: #9213, #9554
Blocking: #9495, #9551 Tester: Federico Montesino Pouzols

Description

All the properties of the PlotAsymmetryByLogValue algorithm should be available.

Use mock-ups here: ​https://github.com/mantidproject/documents/tree/master/Design/Mockups/muon/alc

Please use the way existing widgets are parsed within the MVP set-up, so they are testable.

Add tests for new properties.

Change History

comment:1 Changed 6 years ago by Arturs Bekasovs

  • Blocked By 9554 added

comment:2 Changed 6 years ago by Anders Markvardsen

  • Status changed from new to assigned
  • Owner changed from Arturs Bekasovs to Anders Markvardsen

comment:3 Changed 6 years ago by Anders Markvardsen

  • Priority changed from major to critical
  • Milestone changed from Backlog to Release 3.3

Steve writes:

Including the need to be able to handle Period data and enter grouping information (ticket 9489?), we think these ALC tickets just about cover everything required. After further thought, however, I’d suggest ticket 9489 should ideally be assigned ‘critical’ as Period data frequently needs to be handled in experiments,

comment:4 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Karl Palmen

comment:5 Changed 6 years ago by Nick Draper

  • Milestone changed from Release 3.3 to Release 3.4

Moved to R3.4

comment:6 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Karl Palmen to Raquel Alvarez Banos

comment:7 Changed 6 years ago by Raquel Alvarez Banos

  • Blocking 9495, 9551 added

comment:8 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from assigned to inprogress

Re #9489 Add grouping section to ALC

Changeset: a23cc47fbde7af1c8a3fd89034ef70a24232c605

comment:9 Changed 6 years ago by Raquel Alvarez Banos

Re #9489 Add missing button group name

Changeset: 27ee1f77406394964bb3481ab1247419e98e7930

comment:10 Changed 6 years ago by Raquel Alvarez Banos

Re #9489 Passing ALC grouping to PlotAsymmetryByLogValue

Changeset: 9d3c70e23159d4990ece73d4ef67f05c0c403760

comment:11 Changed 6 years ago by Raquel Alvarez Banos

Re #9489 Adding unit test for custom grouping

Changeset: a59f9a90bede9cb2118efffa1d0cd7803e6f9b47

comment:12 Changed 6 years ago by Raquel Alvarez Banos

Re #9489 Adding period section to interface

Changeset: bffa4254333a48c3df97fe39162a7fff5d4cfb88

comment:13 Changed 6 years ago by Raquel Alvarez Banos

Re #9489 Change logs to info in function name

Changeset: 1d9175f854f7f1a32a00e3987f4710f71287cc20

comment:14 Changed 6 years ago by Raquel Alvarez Banos

Re #9489 Add function to set available periods

Changeset: e7782787e7d1b4f6365e5b850f91f0f0a674d9de

comment:15 Changed 6 years ago by Raquel Alvarez Banos

Re #9489 Update unit test according to new function

Changeset: 30b1881e5efc7a5b98072cf4a16ceebcd192428e

comment:16 Changed 6 years ago by Raquel Alvarez Banos

Re #9489 add function to get red period

Changeset: 341a9a6c3af9db4e9665c26ba0c7378fda7047f5

comment:17 Changed 6 years ago by Raquel Alvarez Banos

Re #9489 Function to get subtract checkbox status

Changeset: 92dc76805cd2ba2d6997f5af5ffcea39495c4c06

comment:18 Changed 6 years ago by Raquel Alvarez Banos

Re #9489 Add function to get green period number

Changeset: e9fb47168308a4391d0a5f6835f40a3eac4ed594

comment:19 Changed 6 years ago by Raquel Alvarez Banos

Re #9489 Set green period if subtract is checked

Changeset: 10eba6c984e3eb288cc0f0080ece7cf664336f01

comment:20 Changed 6 years ago by Raquel Alvarez Banos

Re #9489 Update condition for number of spectra in output workspace

Changeset: 96cc51784b360c54fd5788055f1047595113a26f

comment:21 Changed 6 years ago by Raquel Alvarez Banos

Re #9489 Add comment

Changeset: f7ef7979180db70e8735075fb4be20415301baf6

comment:22 Changed 6 years ago by Raquel Alvarez Banos

Re #9489 Add unit test for custom periods

Changeset: 4d107f9dbe7b33e1ba954734a74e1ad81e5b2545

comment:23 Changed 6 years ago by Raquel Alvarez

  • Status changed from inprogress to verify
  • Resolution set to fixed

This is being verified as ​pull request #351.

comment:24 Changed 6 years ago by Raquel Alvarez Banos

Re #9489 Fix compilation error in rhel6 build

Changeset: 8a0cfca6bc54541aa6c36c0df4fdec92097d8796

comment:25 Changed 6 years ago by Raquel Alvarez Banos

Re #9489 Hopefully fixing rhel6 compilation error

Changeset: 39d784e941463f6400a0461c6fdfdcf13ef5d636

comment:26 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico Montesino Pouzols

comment:27 Changed 6 years ago by Federico Montesino Pouzols

Code and documentation look all good. Tests also pass locally. Lousy-user interactive testing also went well. I could not make it crash or misbehave with the new and old options.

comment:28 Changed 6 years ago by Federico Montesino Pouzols

  • Status changed from verifying to closed

Merge pull request #351 from mantidproject/9489_Add_missing_properties_in_ALC

9489 Add missing properties to ALC Data Loading

Full changeset: ​0a729c39072212846631044c67a26d36d01b5063

comment:29 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10332

Note: See TracTickets for help on using tickets.