ReflectometryReductionOneAuto to C++

[Keith Brown]

While working on #9371 i encountered the problem where i couldn't access ReflectometryReductionOneAuto from the unit tests. This is because it's a python algorithm.

Convert this algorithm to c++

[Nick Draper]

not a blocker

[Keith Brown]

(In #9470) added #9500 and 9501 as blockers here as the new C++ algs will need this update

[Keith Brown]

Refs #9501 Algorithm initialiation

Init method is done, and other files have been created in preparation.

Changeset: 1127f66d4575dda2198e7afb0aed07117e98c546

[Keith Brown]

Refs #9501 Exec and some unit tests

The exec method has been converted as well as many of the unit tests that check for throws

Changeset: 73f5bde1d780f380ac86ee40cfeb74d80ae0793e

[Keith Brown]

Refs #9501 Fix Typo in variable name

fixed a typo in a test for a variable name

Changeset: f8bed81779bd346e187e1859219dadfb9a54a299

[Keith Brown]

Refs #9501 More Unit tests complete

The rest of the unit tests have been ported

ReflectomteryReductionOneAuto recieved a fix to prevent an uncaught out of bounds error. Now throws a different error after a check wiht a sensible error message

ReflectometryWorkflowBase recieved a fix to prevent name-less workspaces causing problems when compared with the default value.

Changeset: 72efae33a44de8b6cc982e871cd2aafaeb96e1ed

[Keith Brown]

Refs #9501 Fully replaced python version

the version number of the c++ version has been changed to 1

The python version of the algorithm and test have been removed

Changeset: b96154457d2fbe02c41a9755dafef83a96fa077f

[Keith Brown]

Refs #9501 Removed mistakenly added file

Added a file meant for another branch by accident, now removed.

Changeset: 795b32e2fb91156f99f7c443812b032548e95d18

[Keith Brown]

Refs #9501 Fix build servers, edited cmake file

broke the build servers by forgetting to modify the cmake files for the files i deleted. the cmake file has been updates

Changeset: 405517c2ec28aa29f34521eeee9f38c4805db311

[Keith Brown]

Refs #9501 Documentation update for the algorithm

Docs for ReflectometryReductionOneAuto have been updated and two usage files added

Changeset: 1bcca7f1199616079e30b5b774083b58fd5b3438

[Martyn Gigg]

There are some compiler warnings in ReflectometryReductionAutoTest: ​http://builds.mantidproject.org/job/develop_clean/163/warnings17Result/

Also, in the TS_ASSERT_THROWS statement there should not be a reference to the exception type but just the plain old exception type. At the momemnt it looks like

TS_ASSERT_THROWS(alg->setProperty("SecondTransmissionRun", m_NotTOF), std::invalid_argument&);

whereas

TS_ASSERT_THROWS(alg->setProperty("SecondTransmissionRun", m_NotTOF),std::invalid_argument);

will suffice.

[Keith Brown]

Refs #9501 Fix Warnings and correct references

The exceptions are no longer references, as it apparently wasn't the right way to do it

The compiler warnings should be fixed

Changeset: a2e1b8bfc77b5fb7a8231ea42d057a66b969edcb

[Keith Brown]

To Tester

Inspect the code of the new C++ version and the python version (on github, as it no longer exists on this branch) to check for any discrepancies

Make sure the C++ unit tests pass.

[Roman Tolchenov]

Merge remote-tracking branch 'origin/feature/9501_ReflectometryReductionOneAuto_to_Cpp'

Full changeset: ​73a405bfdfc74d337d961309edbd06b37758e359

[Stuart Campbell]

This ticket has been transferred to github issue ​10344