Ticket #9526 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Saved fit function loading fails

Reported by: Arturs Bekasovs Owned by: Arturs Bekasovs
Priority: critical Milestone: Release 3.2
Component: GUI Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

To reproduce:

  1. Use the latest master build of Mantid.
  2. Open the Fit Browser.
  3. Add at least two functions to it.
  4. Save the set-up.
  5. Try to load it. Crash.

This is a regression and was introduced in #8030.

Happens because we are trying to create a high-level definition of a composite function while it's in the process of being created, hence doesn't have handlers for all its children.

Change History

comment:1 Changed 6 years ago by Arturs Bekasovs

Refs #9526. Change the way tooltips are updated

Connect to the FitPropertyBrowsers onFunctionChanged() signal and update all the function tooltips at once.

Changeset: 28b419cbc2d37ade1ef7e164851e9e2fede1b862

comment:2 Changed 6 years ago by Arturs Bekasovs

Refs #9526. Set correct tooltips on creation, and fix empty comp func.

Changeset: 7d4f0e32972a563c8870da7cb23b0d42340b8812

comment:3 Changed 6 years ago by Arturs Bekasovs

Tester:

Check that the problem was solved.

Then follow instructions in ​http://trac.mantidproject.org/mantid/ticket/8030#comment:7 to check that the tool-tip functionality wasn't affected.

Play with other less used FitPropertyBrowser features to make sure they are functional.

comment:4 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:5 Changed 6 years ago by Arturs Bekasovs

  • Status changed from assigned to verify
  • Resolution set to fixed

comment:6 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:7 Changed 6 years ago by Roman Tolchenov

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/bugfix/9526_fit_browser_load_crash'

Full changeset: ​b92644735294b9f711b5223980daff56558194e0

comment:8 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10369

Note: See TracTickets for help on using tickets.