Ticket #9538 (closed: fixed)
Improve performance of RectangularDetector::getComponentByName
| Reported by: | Peter Peterson | Owned by: | Peter Peterson |
|---|---|---|---|
| Priority: | major | Milestone: | Release 3.2 |
| Component: | Framework | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Tester: | Karl Palmen |
Description
Since the sub-components of a RectangularDetector have a prescribed name, it is easy to figure out if a component with the correct name exists without having to do the linear search. The speedup should be most observable with SNAP.
Change History
comment:2 Changed 6 years ago by Pete Peterson
Re #9538. Added code for specialized getComponentByName for RectDet
Changeset: 701b45327eb317608f8f15b57f22fbde1b07ca6d
comment:4 Changed 6 years ago by Peter Peterson
- Status changed from assigned to verify
- Resolution set to fixed
This is in feature/9538_rect_det_performance
To test: Try running CreateGroupingWorkspace for SNAP before and after the merge. For me it went from 24 seconds to 4 seconds.
comment:5 Changed 6 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:6 Changed 6 years ago by Karl Palmen
- Status changed from verifying to verify
- Tester Karl Palmen deleted
Build did not work, returning to pool.
comment:7 Changed 6 years ago by Jay Rainey
- Status changed from verify to reopened
- Resolution fixed deleted
- Milestone changed from Backlog to Release 3.2
Commit in comment:2 needs merged to develop.
comment:8 Changed 6 years ago by Peter Peterson
- Status changed from reopened to verify
- Resolution set to fixed
It is in develop (after the reset) again.
comment:9 Changed 6 years ago by Karl Palmen
- Status changed from verify to verifying
- Tester set to Karl Palmen
comment:10 Changed 6 years ago by Karl Palmen
- Status changed from verifying to closed
Merge remote-tracking branch 'origin/feature/9538_rect_det_performance'
Full changeset: 972342c571a561ecac8c80c0bcced7d0fabf6c4e
comment:11 Changed 5 years ago by Stuart Campbell
This ticket has been transferred to github issue 10381
Currently on f20, CreateGroupingWorkspace(InstrumentName="SNAP", GroupDetectorsBy="Column", OutputWorkspace="grouping") takes ~24 seconds.