Ticket #9541 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Add the capability of holding a workspace of monitor data within another workspace

Reported by: Russell Taylor Owned by: Russell Taylor
Priority: critical Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: #9540, #9542, #9544, #9545 Tester: Alex Buts

Description

This is implementing the design given in https://github.com/mantidproject/documents/blob/master/Design/MonitorsInLiveData.md

It includes the changes to MatrixWorkspace as well as the addition of the ExtractMonitorWorkspace algorithm.

Change History

comment:1 Changed 6 years ago by Russell Taylor

  • Blocking 9542 added

comment:2 Changed 6 years ago by Russell Taylor

  • Blocking 9543 added

comment:3 Changed 6 years ago by Russell Taylor

  • Blocking 9544 added

comment:4 Changed 6 years ago by Russell Taylor

  • Blocking 9545 added

comment:5 Changed 6 years ago by Russell Taylor

  • Status changed from new to assigned

comment:6 Changed 6 years ago by Russell Taylor

  • Status changed from assigned to inprogress

comment:7 Changed 6 years ago by Russell Taylor

Re #9541. Precursor: Fix indentation issues.

Changeset: 779b78c24d05942d2eb9257c940cf1e35b94a7b0

comment:8 Changed 6 years ago by Russell Taylor

Re #9541. Add a monitor workspace member to MatrixWorkspace.

Along with simple getter, setter and test.

Changeset: 3d067a38e2306c885752fdd1cb6dd4081a712e3c

comment:9 Changed 6 years ago by Russell Taylor

Re #9541. Add a test of the factory behaviour.

The workspace factory should not propagate monitor workspaces.

Changeset: b39cf7d557aa97c59f36e7e2b918ae908d56fbe0

comment:10 Changed 6 years ago by Russell Taylor

Re #9541. Add ExtractMonitorWorkspace algorithm and test.

Changeset: c17db86b99bc9645374b6ae2df07b590397c7b60

comment:11 Changed 6 years ago by Russell Taylor

Re #9541. Correct doxygen omission.

Changeset: 2b9d919185f8ef6541faa0f2f2a92358d614ad59

comment:12 Changed 6 years ago by Russell Taylor

  • Status changed from inprogress to verify
  • Resolution set to fixed

To test: Test first by inspection of code and tests. This is not a complicated change and the associated algorithm is trivial. It's not possible to test this from MantidPlot without changing code (apart from testing that the ExtractMonitorWorkspace algorithm fails). You'd have to edit some loader/workspace creation algorithm to add a monitor workspace. Or you could decide that inspection is sufficient.

The things that will lean on this change are coming in other tickets.

comment:13 Changed 6 years ago by Alex Buts

  • Status changed from verify to verifying
  • Tester set to Alex Buts

comment:14 Changed 6 years ago by Alex Buts

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9541_matrixws_monitorws_member'

Full changeset: a4e017ccc99794f45204b89b3460a3873918583e

comment:15 Changed 6 years ago by Russell Taylor

  • Blocking 9543 removed

comment:16 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue 10384

Note: See TracTickets for help on using tickets.