Ticket #9557 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Incorrect StartX/EndX when switching workspaces

Reported by: Arturs Bekasovs Owned by: Raquel Alvarez Banos
Priority: major Milestone: Release 3.4
Component: Muon Keywords:
Cc: Blocked By: #9771
Blocking: Tester: Federico M Pouzols

Description (last modified by Raquel Alvarez Banos) (diff)

To reproduce:

  1. Load a workspace.
  2. Go to Data Analysis tab and fit it.
  3. Load a different one.
  4. Go to Data Analysis tab - StartX and EndX don't have sane values.

Seems to happen on the latest master build but not in 3.1.0.

Change History

comment:1 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:2 Changed 6 years ago by Arturs Bekasovs

This will likely get fixed in #9650.

comment:3 Changed 6 years ago by Nick Draper

  • Milestone changed from Release 3.2 to Backlog

Moved to Backlog at the code freeze of release 3.2

comment:4 Changed 6 years ago by Anders Markvardsen

  • Blocked By 9771 added

(In #9771) Note reading #9557 the reason for this bug may not be related to changes in muonanalysis...

comment:5 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Arturs Bekasovs to Anders Markvardsen

comment:6 Changed 6 years ago by Anders Markvardsen

  • Owner changed from Anders Markvardsen to Raquel Alvarez Banos

comment:7 Changed 6 years ago by Raquel Alvarez Banos

You do not even need to load a different workspace: if you set a fitting range, go to a different tab, and go back to Data Analysis Tab, StartX and EndX do not have the same values. I am fixing both issues at once.

comment:8 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from assigned to inprogress

Re #9557 Keeping muon fitting rage to last values

Changeset: c3dc2d7c73605ebe41f1aa75c8879e499cee7393

comment:9 Changed 6 years ago by Raquel Alvarez Banos

  • Status changed from inprogress to verify
  • Resolution set to fixed
  • Description modified (diff)
  • Milestone changed from Backlog to Release 3.4

For tester:

  • Go to Interfaces -> Muon -> Muon Analysis
  • Reproduce the steps in the description
  • Reproduce steps in comment7
  • Check that in both cases StartX and EndX stay the same.

comment:10 Changed 6 years ago by Federico M Pouzols

  • Status changed from verify to verifying
  • Tester set to Federico M Pouzols

comment:11 Changed 6 years ago by Federico M Pouzols

The branch needs to be merged into develop with a 'checkbuild'.

This ticket is related to #10842 and, to a lesser extent, ##5115.

comment:12 Changed 6 years ago by Raquel Alvarez Banos

Should be ready to test now.

comment:13 Changed 6 years ago by Federico M Pouzols

  • Status changed from verifying to closed

It seems to work well, after changing tabs and dataset the start/end lines are where they should be. Code changes take care of proper initialization and re-use of already initialized values.

comment:14 Changed 6 years ago by Federico Montesino Pouzols

Merge remote-tracking branch 'origin/bugfix/9557_incorrect_fitting_limits_when_switching_ws'

Full changeset: ​037e79f146b2a2d602fdd20a954d72ca0398ea0e

comment:15 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10400

Note: See TracTickets for help on using tickets.