Ticket #9631 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Improve LoadInstrument idlist error handling

Reported by: Nick Draper Owned by: Nick Draper
Priority: major Milestone: Release 3.2
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Samuel Jackson

Description

If you have an idlist entry with the end < start you get an unhelpful error message 

 Vestor <T> too long (at least that is what you get on windows)

Make the error message better.

Attachments

NIMROD_Definition.xml​ (131.3 KB) - added by Nick Draper 6 years ago.

Change History

Changed 6 years ago by Nick Draper

comment:1 Changed 6 years ago by Nick Draper

re #9631 improve error message

Changeset: 254378b57c8833a5a92c58b7b3357f9c31a8db5f

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned

comment:3 Changed 6 years ago by Nick Draper

There was another commit that went to the wrong ticket #9361

re #9361 this one should not break the tests

Changeset: 2bb9e3180c9bb15458976d91a396972bfde14188

comment:4 Changed 6 years ago by Nick Draper

  • Status changed from assigned to verify
  • Resolution set to fixed

to test:

  1. Load the attached file using LoadEmptyInstrument
  2. Check the error message is better than "Vector <T> Too Long"
  3. Check the unit tests and system tests have passed as they show you the all of the other instrument definitions still load.

comment:5 Changed 6 years ago by Samuel Jackson

  • Status changed from verify to verifying
  • Tester set to Samuel Jackson

comment:6 Changed 6 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge remote-tracking branch 'origin/feature/9631_idlist_error_message'

Full changeset: ​30a72a2d09388a9b5406439d56ac672bab11962f

comment:7 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10474

Note: See TracTickets for help on using tickets.