Ticket #9640 (closed: fixed)

Opened 6 years ago

Last modified 5 years ago

Indirect Load Ascii Interface

Reported by: Ricardo Leal Owned by: Dan Nixon
Priority: major Milestone: Release 3.3
Component: Framework Keywords:
Cc: Blocked By:
Blocking: Tester: Roman Tolchenov

Description

  • Integrate ILL IN16B in the interface Load Ascii. Loader is done : LoadIndirectILL
  • For IN10, 13, and 16 it looks like the units are wrong. We have Energy instead of DeltaE. The spectra axis is good though.
  • For the files *.inx the run_number appears as a path to a file. The indirect load analysis complain about that string. A conversion to a digits sorts this out.

In python I'm sorting this temporary with: 

mtd['IN10_P3OT_350K_silicon111_red'].getAxis(0).setUnit('DeltaE')

r.keys()
# Out[29]: ['facility', 'run_number', 'run_title']


r['run_number'] = '123'

# Save as nexus in the end

Change History

comment:1 Changed 6 years ago by Ricardo Leal

  • Summary changed from Indirect Load ILL to Indirect Load Ascii Interface

comment:2 Changed 6 years ago by Nick Draper

  • Status changed from new to assigned
  • Owner set to Samuel Jackson

comment:3 Changed 6 years ago by Samuel Jackson

  • Status changed from assigned to inprogress

Refs #9640 Add message for failure case.

Changeset: 2be7a4e27c5fabd5e9f62be06a97fdeb5076e769

comment:4 Changed 6 years ago by Samuel Jackson

Trac seems to have missed some of the commits for this ticket. Look here for the full branch history:

​https://github.com/mantidproject/mantid/compare/bugfix/9640_load_ascii_bug

Last edited 6 years ago by Samuel Jackson (previous) (diff)

comment:5 Changed 6 years ago by Samuel Jackson

Refs #9640 Fix for failing system tests.

Changeset: b9d1cfa6a3ae8d5d1f0be25704d8906440387df2

comment:6 Changed 6 years ago by Samuel Jackson

Refs #9640 Swap run number to be zero.

Changeset: 6116755719799ff2c820ee6dcde3081b7ec9c3da

comment:7 Changed 6 years ago by Samuel Jackson

To Test

The third issue cannot be easily resolved as the .inx format does not store the run number anywhere in the file. For now I have set it to be zero.

The issues listed in the description should now be fixed. There is a .inx file in the system tests and a IN16B nexus file in the AutoTestData.

comment:8 Changed 6 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

comment:9 Changed 6 years ago by Samuel Jackson

  • Status changed from verify to reopened
  • Resolution fixed deleted

comment:10 follow-up: ↓ 12 Changed 6 years ago by Samuel Jackson

  • Status changed from reopened to inprogress

Refs #9640 Missed int conversion.

Changeset: 9de9361b4d04517ff32e9ccac01b0da0c100ab26

comment:11 Changed 6 years ago by Samuel Jackson

Refs #9640 Update reference results.

Changeset: 1bbd64f7938e4cec1ebab2e5d8c29cfa0c2c135d

comment:12 in reply to: ↑ 10 Changed 6 years ago by Andrei Savici

Replying to Samuel Jackson:

Refs #9640 Missed int conversion.

Changeset: 9de9361b4d04517ff32e9ccac01b0da0c100ab26

You cannot add strings and ints in python

comment:13 Changed 6 years ago by Samuel Jackson

Refs #9640 Int conversion should have been string conversion.

Changeset: 09dd7c5379a06891c35dcbf3102f106cfd37f9dd

Last edited 6 years ago by Samuel Jackson (previous) (diff)

comment:14 Changed 6 years ago by Samuel Jackson

Refs #9640 Update reference results again.

Had it pointed at the wrong repo first time.

Changeset: 5b2d8a0c25cf38efb98e8a28052028c88bf859e1

comment:15 Changed 6 years ago by Samuel Jackson

  • Status changed from inprogress to verify
  • Resolution set to fixed

To Test: See comment 7.

comment:16 Changed 6 years ago by Nick Draper

  • Owner changed from Samuel Jackson to Dan Nixon

comment:17 Changed 6 years ago by Roman Tolchenov

  • Status changed from verify to verifying
  • Tester set to Roman Tolchenov

comment:18 Changed 6 years ago by Roman Tolchenov

Merge branch 'master' into bugfix/9640_load_ascii_bug

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectNeutron.py

Re #9640

Changeset: 0bde4d3cb033c8ae0e933509f2a30022aee9e11a

comment:19 Changed 6 years ago by Roman Tolchenov

Merge branch 'bugfix/9640_load_ascii_bug' into develop

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectNeutron.py

Re #9640

Changeset: ca83c669b0dd53f74aec5f5f7150c11a004292a4

comment:20 Changed 6 years ago by Martyn Gigg

The merge to develop hasn't gone so well. Somehow the diff markers have been left: ​https://github.com/mantidproject/mantid/blob/develop/Code/Mantid/scripts/Inelastic/IndirectNeutron.py and this has broken the system tests.

comment:21 Changed 6 years ago by Roman Tolchenov

Re #9640. Restore the correct version of a file.

Changeset: d7aaa42354cbeab8c79541abc1f8150a44cf410a

comment:22 Changed 6 years ago by Samuel Jackson

  • Status changed from verifying to closed

Merge branch 'bugfix/9640_load_ascii_bug' of github.com:mantidproject/mantid into bugfix/9640_load_ascii_bug

Full changeset: ​d250972cb649872ec607e0caa32e057c3cc5bad2

comment:23 Changed 6 years ago by Roman Tolchenov

Merge branch 'master' into bugfix/9640_load_ascii_bug

Conflicts:

Code/Mantid/scripts/Inelastic/IndirectNeutron.py

Re #9640

Full changeset: ​0bde4d3cb033c8ae0e933509f2a30022aee9e11a

comment:24 Changed 6 years ago by Roman Tolchenov

Merge remote-tracking branch 'origin/bugfix/9640_load_ascii_bug'

Full changeset: ​d497d539ad9856881e98423d261858838363639a

comment:25 Changed 6 years ago by Martyn Gigg

Merge branch 'bugfix/9640_load_ascii_bug'

Full changeset: ​f6a8a4e7513559888650a20bfa8640aa738ed675

comment:26 Changed 5 years ago by Stuart Campbell

This ticket has been transferred to github issue ​10483

Note: See TracTickets for help on using tickets.